fix(iovec-util): rework IOVEC_MAKE_STRING() to work with compound initialized input - #414
Open
deepin-ci-robot wants to merge 1 commit into
Conversation
…tialized input
This avoids the ({}) that IOVEC_MAKE_STRING() so far used and might
cause a memory corruption if the parameter passed in is itself allocated
via a compount initialized array or so.
Also, this makes sure both IOVEC_MAKE_STRING() and IOVEC_MAKE() accept
'const' parameters without this causing a compiler warning.
Changes:
- Add debian/patches/fix-iovec-util-rework-iovec-make-string-compound-input.patch
- Modify debian/patches/series
- Modify debian/changelog
Upstream: systemd/systemd@33d1feb
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
IOVEC_MAKE_STRING()was implemented with a GCC statement expression (({})). When the parameter passed in is itself allocated via a compound initialized array (or similar construct), this could cause memory corruption. In addition, bothIOVEC_MAKE_STRING()andIOVEC_MAKE()produced compiler warnings when passedconstparameters.What This PR Changes
Reworks
IOVEC_MAKE_STRING()to use a small static inline helperiovec_make_string()that fills a compound-literalstruct iovecinstead of a statement expression, and makesIOVEC_MAKE()cast the base pointer tovoid*so that both macros acceptconstparameters without compiler warnings.Problem Solved After the Change
Eliminates the risk of memory corruption when
IOVEC_MAKE_STRING()is used with compound initialized input, and removes compiler warnings forconstinputs.Changes
Upstream
systemd/systemd@33d1febb
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org