fix(tpm2): assign noDA attribute to TPM2 objects not dependant on a PIN - #419
Open
deepin-ci-robot wants to merge 1 commit into
Conversation
All the keys are high-entropy keys that cannot be practically bruteforced and thus don't require protection from dictionary attacks. With the exception of PINs, of course, which are low-entropy and user provided. Note that a new enrollment is required for unlocking while in DA lockdown to function. Existing enrollments are subject to DA lockout. Changes: - Add debian/patches/fix-tpm2-assign-noda-attribute-not-dependant-on-pin.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@9bf9158 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
TPM2 objects sealed by systemd-cryptenroll were not assigned the noDA attribute, so they were subject to the TPM's dictionary attack (DA) protection logic. For high-entropy keys protected only by a PCR policy this provides no benefit, and enrollments could hit DA lockout and fail to unlock.
What This PR Changes
Backport of upstream systemd commit 9bf91584: assign the noDA attribute to TPM2 sealed objects that are not dependant on a PIN. All keys are high-entropy keys that cannot be practically bruteforced and thus don't require protection from dictionary attacks — with the exception of PINs, which are low-entropy and user provided, so DA protection is enabled only when a PIN is used.
Note that a new enrollment is required for unlocking while in DA lockdown to function; existing enrollments are subject to DA lockout.
Problem Solved After the Change
TPM2-backed LUKS2 unlocking no longer enters DA lockout for non-PIN enrollments, avoiding spurious unlock failures after repeated attempts (upstream issue #30330).
Changes
Upstream
systemd/systemd@9bf91584 (PR #30728)
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org