fix(basic): fix overflow detection in sigbus_pop - #421
Open
deepin-ci-robot wants to merge 1 commit into
Open
Conversation
The current check checks for n_sigbus_queue being greater than or equal to SIGBUS_QUEUE_MAX, when it should be just greater than as n_sigbus_queue being SIGBUS_QUEUE_MAX indicates that the queue is full, but not overflowed. Changes: - Add debian/patches/fix-basic-sigbus-overflow-detection.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@b4a9d19 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
In the SIGBUS queue handling code (
src/basic/sigbus.c), the overflow detection insigbus_pop()usedc >= SIGBUS_QUEUE_MAXinstead ofc > SIGBUS_QUEUE_MAX. Sincen_sigbus_queueequal toSIGBUS_QUEUE_MAXonly indicates that the queue is full (not overflowed),sigbus_pop()could incorrectly report-EOVERFLOWwhile the queue still contains valid entries.What This PR Changes
Backport of upstream commit b4a9d19e4ec5 ("basic: fix overflow detection in sigbus_pop"), which changes the bounds check in
sigbus_pop()fromc >= SIGBUS_QUEUE_MAXtoc > SIGBUS_QUEUE_MAXso that a full queue is no longer treated as overflowed. The commit also clarifies two related comments ("overflow" → "overflowed").Problem Solved After the Change
sigbus_pop()now only reports-EOVERFLOWwhen the SIGBUS queue has genuinely overflowed (more thanSIGBUS_QUEUE_MAXentries were recorded), preventing spurious EOVERFLOW errors when the queue is merely full.Changes
Upstream
systemd/systemd@b4a9d19
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org