fix(logind): don't setup idle session watch for lock-screen and greeter - #422
Open
deepin-ci-robot wants to merge 1 commit into
Open
Conversation
Reason to skip the idle session logic for these session classes is that they are idle by default. Changes: - Add debian/patches/fix-logind-idle-session-watch-lock-screen-greeter.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@508b478 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
When
StopIdleSessionSec=is configured, systemd-logind sets up a stop-on-idle session watch for every session, includinggreeterandlock-screensessions. These session classes are idle by definition (they have no meaningful user activity), so the idle watch immediately considers them idle and the stop-idle-session logic can terminate them incorrectly.What This PR Changes
Skip the idle session watch (stop-on-idle timer) for
SESSION_GREETERandSESSION_LOCK_SCREENsession classes insession_setup_stop_on_idle_timer(), and document inman/logind.conf.xmlthatStopIdleSessionSec=does not apply togreeterorlock-screensessions.Problem Solved After the Change
Greeter and lock-screen sessions are no longer subject to the idle-session timeout, so they will not be stopped by the
StopIdleSessionSec=logic while sitting idle.Changes
Upstream
systemd/systemd@508b4786
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org