fix(resolved): do not append goodby packet entries to known answers section - #424
Open
deepin-ci-robot wants to merge 1 commit into
Conversation
…ection When we receive a goodby packet about a host, and we have a cache entry about the host, we do not immediately remove the cache entry, but update it with TTL 1. See RFC 6762 section 10.1 and 3755027c2cada70345c96787a9b5569994dd23ed. If we receive a request soon after the goodby packet, previously the entry was included in the known answers section of the reply. But such information should not be appended. Follow-up for 3755027c2cada70345c96787a9b5569994dd23ed. Changes: - Add debian/patches/fix-resolved-mdns-do-not-append-goodby-entries-to-known-answers.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@04d4086 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
When systemd-resolved receives an mDNS goodby packet about a host, the cache entry is not removed immediately but updated with TTL 1 (RFC 6762 section 10.1). If a request arrives soon after the goodby packet, the dying cache entry was incorrectly included in the known answers section of the reply.
What This PR Changes
Skip cached goodby entries (records with TTL <= 1) when exporting shared cache records into a reply packet in
dns_cache_export_shared_to_packet(), so they are no longer appended as known answers.Problem Solved After the Change
Cached goodby packet entries are no longer appended to the known answers section of mDNS replies, as required by RFC 6762 section 10.1.
Changes
Upstream
systemd/systemd@04d4086 (PR #30096)
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org