fix(network): also drop reference for DHCP server address - #430
Open
deepin-ci-robot wants to merge 1 commit into
Open
Conversation
The Address object should never freed after it is referenced. So, this should not change any behavior. Just for safety. Changes: - Add debian/patches/fix-network-drop-dhcp-server-address-reference.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@8ae3a4f Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
In
networkd, when aNetworkobject has a DHCP server address configured, theAddressobject stored innetwork->dhcp_server_addressis only removed from the per-section hashmap when it is freed. If other references keep theAddressobject alive (or if it is freed and later reused), the stale pointer innetwork->dhcp_server_addresscould dangle, as the reference held bynetwork->dhcp_server_addresswas never dropped inaddress_free().What This PR Changes
Backports upstream systemd commit 8ae3a4f5e282a1fb024e7bb5d6cf1b83037a2395 (PR #30631):
address_free()now also clearsaddress->network->dhcp_server_addresswhen the freedAddressobject is the one referenced by the network's DHCP server address, ensuring the reference is dropped consistently.Problem Solved After the Change
The
network->dhcp_server_addresspointer can no longer dangle after the correspondingAddressobject is freed, preventing potential use-after-free issues. Per upstream, this should not change any behavior in practice — it is a safety measure.Changes
Upstream
systemd/systemd@8ae3a4f
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org