fix(service): don't determine selinux label for socket activation with RootImage= - #433
Open
deepin-ci-robot wants to merge 1 commit into
Conversation
…h RootImage= We cannot determine the SELinux label ahead of time if RootImage= is used, since we'd have to mount the image then, hence don't, and handle this cleanly, and gracefully. While we are at it, stop "reaching over" so much from the socket code to the service code, and instead provide function that most of the hard work in service.c that socket.c just calls. While we are at it, add debug logging and stuff. I noticed the issue when also noticing #30560, but that one is harder to fix, hence I avoided it for now. Changes: - Add debian/patches/fix-service-selinux-label-socket-activation-rootimage.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@8017ed7 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
When a service uses
RootImage=(orExtensionImages=/ExtensionDirectories=), socket activation attempted to pre-determine the SELinux label of the service binary by chasing the executable path on the host filesystem. This cannot work because the binary lives inside the image, which is not mounted at that point, leading to failed lookups and ungraceful error handling during socket activation.What This PR Changes
Backport of upstream commit 8017ed7e0e0ffaafcf9856f963928ca2a21340b6: move the SELinux label determination out of socket.c into a new
service_determine_exec_selinux_label()function in service.c. The new function gracefully skips label determination (returning-ENODATA) whenRootImage=,ExtensionImages=orExtensionDirectories=are configured, since paths cannot be chased through images, and adds debug logging.Problem Solved After the Change
Socket activation of services using
RootImage=no longer attempts to determine the SELinux label ahead of time; the missing label is handled cleanly and gracefully.Changes
Upstream
systemd/systemd@8017ed7
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org