Repository navigation
The recall bench waits for alignment and governance to settle before it scores a round (#588) - #1005
Merged
Merged
Conversation
…it scores a round Signed-off-by: Jeremy Capps <jeremylwcapps@gmail.com>
WaylandYang
approved these changes
Sep 29, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Approving. Thanks @jeremycapps, this closes the gap you found in #1002.
Reviewed at 35a3da8. The query matches the jobs table (status, run_at), the one-minute window covers the debounce, and marking a run settled: false and naming it under the table keeps a snapshot out of the means.
Two notes, neither blocks this:
- A failed job that is queued again with a backoff longer than a minute will read as settled. Worth a line in the README if you see it happen in a round.
- The count covers every base in the database, as the extraction wait above it does. That is fine on a bench database that holds one run at a time.
The server-side idle signal is worth proposing. Please open an issue for it first so we can agree on the shape before any code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1002 (#588).
Why
recall.mjsstopped waiting onceextract_document/process_documentwere done and scored straight away. But alignment, governance, time resolution and adjudication keep running after extraction, adding facts and deciding pairs. On a local round (gemini-3.5-flash, 4 SEC filings) the earnings release had 552 facts when the round was recorded and 565 an hour later, and the pair counts moved too. So each record was a snapshot at whatever moment extraction happened to end, which adds noise to theknownshown/empty comparison that has nothing to do withknown.What changes
running, orqueuedwithrun_atdue within a minute. That covers alignment's few-second debounce and jobs that re-queue themselves with a short delay; a job scheduled further out isn't part of this round.settled: false.settledandsettleSeconds.--tableshows the wait as a row and names any run that didn't settle, so a snapshot can't hide inside a mean.idleevent on/kbs/{id}/eventssent once a finished job's follow-ups are committed). I'm happy to propose that separately if you think it's worth it.secondscolumn is unchanged: it's read fromchunks.extracted_at, not from when the bench stopped waiting.Verified
noopjob due in 20 s: it waited, then reported settled after 24 s once the worker finished the job. With anoopdue in 5 minutes it settled immediately.--tableon round 1's record shows the new row (-for a record from before this change).