Conversation
… rule writes Signed-off-by: dada-yan <BinjunYann@gmail.com>
Signed-off-by: dada-yan <BinjunYann@gmail.com>
|
The content here is decision material — it states a policy and asks maintainers to approve it — and the thinking in it is good. My objection is only about where it lives.
Please give this its own numbered record in #832 in this same batch is the pattern to copy: it moved its reasoning into One thing that is not my call and that I have flagged for the maintainer: whether the executable prototype itself belongs in the repository. Specific to this one: the unit policy table and the |
|
Adding one more, on The reason for isolating it is understood and half right — But the isolation costs more than it saves, because of what the page is being asked to answer. 0032's open question is "How deep before the picker loses", with the record's own example being that
So what it demonstrates is the interaction shape in a mock, and the shape was not in doubt. Put it in The policy module and its tests are a different matter; |
ADR 0032 requires unit/datatype checks for the picker but leaves missing units and explicit dimensionless declarations undefined. This draft proposes a conservative declaration policy and provides an isolated executable editor/policy experiment; it does not tighten production rule writes or enable B2.
Prefer exact known units, missing/ambiguous as unknown, no conversions, same-unit add/subtract and numeric scaling. Decide whether exact
1denotes explicit unitless and which known declarations belong in the initial allowlist. The report explains the deliberate compatibility change, short FOR SHARE transaction boundary, metadata-only legacy fallback and remaining actual-backend E2E work.Validation: 10 Node policy tests passed on Linux, a real PostgreSQL lock experiment observed a blocked declaration update until writer commit, and a headless Chromium local picker check passed save/reopen, invalid constants, failed-save retry and protected legacy metadata editing. The browser is a standalone model, not Utopia API E2E. Production APIs, UI and dependencies are unchanged.
The existing ADR status remains unchanged; the appended proposed-revision link points to the exact decisions and reproduction commands. This is a contract-review draft, not a claim that #488 or B2 is complete. The separate API mismatch fix is #838.
Refs #488