Swap em dash for hyphen in pagination summary (ENG-3360) - #107
Merged
Merged
Conversation
Co-Authored-By: sahaj <sahaj@deeptrust.ai>
Contributor
Original prompt from sahaj
|
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENG-3360 removes em dashes from customer-facing UI copy.
Paginationrenders the only one in this package's shipped copy, so every paginated table in web showed it:Character swap only. Remaining em dashes in
libare in code comments and a Storybook story's placeholder, which aren't customer-facing. Consumed by deeptrust-ai/web#812, which bumps the submodule pointer to this commit.Link to Devin session: https://app.devin.ai/sessions/87f88d4270fc45c181d56d00fe9d0608
Requested by: @sahajgandhi-deeptrust