Skip to content

Swap em dash for hyphen in pagination summary (ENG-3360) - #107

Merged
sahajgandhi-deeptrust merged 1 commit into
mainfrom
devin/eng-3360-pagination-em-dash
Aug 25, 2026
Merged

sahajgandhi-deeptrust merged 1 commit into
mainfrom
devin/eng-3360-pagination-em-dash

Conversation

@sahajgandhi-deeptrust

@sahajgandhi-deeptrust sahajgandhi-deeptrust commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

ENG-3360 removes em dashes from customer-facing UI copy. Pagination renders the only one in this package's shipped copy, so every paginated table in web showed it:

-`Showing ${itemFrom} — ${itemTo} of ${totalItems}`
+`Showing ${itemFrom} - ${itemTo} of ${totalItems}`

Character swap only. Remaining em dashes in lib are in code comments and a Storybook story's placeholder, which aren't customer-facing. Consumed by deeptrust-ai/web#812, which bumps the submodule pointer to this commit.

Link to Devin session: https://app.devin.ai/sessions/87f88d4270fc45c181d56d00fe9d0608
Requested by: @sahajgandhi-deeptrust


Open in Devin Review

Co-Authored-By: sahaj <sahaj@deeptrust.ai>
@devin-ai-integration

Copy link
Copy Markdown
Contributor
Original prompt from sahaj

Please work on ticket "Remove em dashes from all customer-facing UI pages" (ENG-3360)

@playbook:playbook-b0d9a34380374c3e903d900d340d8da7

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@ali616csayed ali616csayed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahajgandhi-deeptrust
sahajgandhi-deeptrust merged commit e8e7099 into main Aug 25, 2026
9 checks passed
@sahajgandhi-deeptrust
sahajgandhi-deeptrust deleted the devin/eng-3360-pagination-em-dash branch August 25, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants