Skip to content

drive e2e from scenario yaml fixtures - #105

Merged
atkrad merged 2 commits into
mainfrom
drive-e2e-from-scenarios
Aug 26, 2026
Merged

drive e2e from scenario yaml fixtures#105
atkrad merged 2 commits into
mainfrom
drive-e2e-from-scenarios

Conversation

@atkrad

@atkrad atkrad commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Drive Kind e2e from scenarios/*/e2e.yaml instead of typed expect.yaml under internal/e2e/testdata/.
  • Run fixtures in-process with nabattest.WithDir so parallel cases do not chdir.
  • Resolve --spec, kubeconfig, platform file, and env files against the spec directory, not process cwd.

Related

Refs #39
Refs #41

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing
  • nix run .#test-e2e on a live Kind cluster

Labels

  • One of: kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- replace testdata expect.yaml with scenarios/*/e2e.yaml
- run Kind cases in-process with nabattest.WithDir
- resolve spec and env files against the spec directory
@github-actions github-actions Bot added kind/docs Documentation only area/cli Commands, flags, UX copy area/spec deployah.yaml schema or loading area/testing Scenarios, harness, goldens area/ci GitHub Actions and release packaging labels Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.60837% with 51 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/testing/subset.go 74.13% 30 Missing ⚠️
internal/testing/e2e_fixture.go 86.40% 17 Missing ⚠️
internal/cmd/root.go 50.00% 2 Missing ⚠️
internal/spec/loader.go 90.90% 1 Missing ⚠️
internal/testing/scenario_discovery.go 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change and removed kind/docs Documentation only labels Aug 26, 2026
@atkrad
atkrad merged commit ff4fb31 into main Aug 26, 2026
17 checks passed
@atkrad
atkrad deleted the drive-e2e-from-scenarios branch August 26, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci GitHub Actions and release packaging area/cli Commands, flags, UX copy area/spec deployah.yaml schema or loading area/testing Scenarios, harness, goldens kind/chore Cleanup, deps, CI, or refactor with no user-facing change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant