Pass over hidden and disabled widgets in the blocked Tab walk - #291
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Pass over hidden and disabled widgets in the blocked Tab walk#291rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
The layer's Tab traversal picked the next widget with a Tab focus policy without asking whether it is shown or enabled, so Tab could land on the field of a collapsed section or on a button that is faded out, where the keyboard is left on something that is not there. The default traversal skips those; do the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer's Tab traversal (
base::FocusNextPrevChildBlocked) picked the next widget with a Tab focus policy without checking whether it is shown or enabled, so Tab could land on the field of a collapsed section (the explanation of a quiz in the poll box) or on a button that is faded out, leaving the keyboard on something that is not there. Qt's default traversal skips those; do the same.Needed by the tdesktop poll box Tab changes.