Skip to content

Trim invisible characters at string edges #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meh7an wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Trim invisible characters at string edges #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion ui/text/text.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2373,10 +2373,33 @@ bool IsReplacedBySpace(QChar ch) {
|| (ch.unicode() >= 8232 && ch.unicode() <= 8237);
}

namespace {

[[nodiscard]] bool IsBlankLike(QChar ch) {
// Hand-picked: neither Default_Ignorable nor Cf is a safe criterion,
// both admit characters that shape or render. These are only the ones
// that are zero-width and Joining_Type=Transparent.
switch (ch.unicode()) {
case 0x200B: // zero width space
case 0x2060: // word joiner
case 0x2061: // function application
case 0x2062: // invisible times
case 0x2063: // invisible separator
case 0x2064: // invisible plus
case QChar::ByteOrderMark: // zero width no-break space
return true;
default:
break;
}
return false;
}

} // namespace

bool IsTrimmed(QChar ch) {
return ((ch != QChar::ObjectReplacementCharacter) && IsSpace(ch))
|| IsBad(ch)
|| (ch == QChar(8203)); // zero width space
|| IsBlankLike(ch);
}

QSize CountOptimalTextSize(
Expand Down