Dispatch the showMenu action of an expandable painted item - #365
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Dispatch the showMenu action of an expandable painted item#365rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
An item of a painted list that opens something of its own - a picker of the variants of an emoji - reports itself expandable, and the Windows bridge expands and collapses such an element through the showMenu action. Advertise the action with the expandable state and dispatch it to the owner by identity, like the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An item of a painted list that opens something of its own — the picker of an emoji's skin tones — reports itself
expandable, and the Windows UIA bridge expands and collapses such an element through theshowMenuaction (desktop-app/patches#266 makes the bridge offer the ExpandCollapse pattern for it).Ui::Accessible::ItemadvertisesshowMenuAction()when the child state is expandable and dispatches it by identity to a newRpWidget::accessibilityChildShowMenu()(default no-op), like SetFocus and Invoke. Note: a new virtual onRpWidget— a full rebuild of dependents is needed.Used by telegramdesktop/tdesktop emoji panel variants PR.