Repository navigation
Reject illegal fills before mutating order quantities - #12
Merged
Merged
Conversation
dev-belly
marked this pull request as ready for review
October 11, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying a partial or full fill to a new, cancelled, rejected or expired order raised OrderStateError after incrementing filled_base, leaving rejected operations in the order's accounting state. Validate the state transition before committing the new filled quantity.
Validation: all eight new invalid-state/quantity regressions fail on the baseline. The fixed tree passes 867 tests; 152 tests are skipped locally because the optional C++ extension is not built on this Windows environment. Ruff/format for 135 files, mypy for 101 files, dependency compatibility and the eight-strategy CLI demo pass. GitHub CI retains Python, C++ differential and sanitizer coverage.