Skip to content

fix(governance): separate portfolio property readback - #778

Draft
devantler wants to merge 1 commit into
mainfrom
codex/property-readback-773-9524
Draft

devantler wants to merge 1 commit into
mainfrom
codex/property-readback-773-9524

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The property rollout cannot finish because its verification view omits declared repositories. It correctly keeps the old property until the complete portfolio can be verified.

What

Separate portfolio verification from configuration changes, so every declared repository can be checked without extending the writer's reach. Keep incomplete results as a deployment blocker and require approval for the verification selection.

Part of #773

@github-code-quality

github-code-quality Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 2d44f4d codex/property-readb... b5aaba1 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 2d44f4d codex/property-readb... b5aaba1 +/-
100% 100% 0%

Go / code-coverage/go

main 2d44f4d codex/property-readb... b5aaba1 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 27, 2026 02:20 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

At signed head b5aaba145f3e602988caa993d213123df96123b5, the new subprocess-boundary regression failed against the old code because the writer was used for value readback and the alternate credential was inherited by unrelated commands. It now passes: only the organization-values GET receives the verifier, mutations retain the writer, unrelated child commands do not inherit the alternate credential, and an absent verifier blocks readback without fallback.

The full rendered-property/reconciler suite, generated-source parity, executable two-repository selector fixture, workflow boundary assertions, Go vet and whitespace checks pass locally. Hosted CI is still pending. Deployment remains held for the requested maintainer approval of the dedicated verification selection; no installation grants have changed.

The previous native rollout 40436385072 initialized assignments but correctly refused retirement after incomplete readback. Independent native inspection now confirms all 26 declared repositories have the four desired values plus the retained documentation value, all 104 managed assignments are Ready/Synced, and the Go template's previously observed missing-property warning is absent. This does not clear the incomplete workflow or the final four-property acceptance gate.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T02:25:15.779721Z b5aaba1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: b5aaba145f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

At b5aaba145f3e602988caa993d213123df96123b5, all 265 unique contexts are complete: 209 successful and 56 skipped, none failing or pending. Codex reviewed this exact commit without major issues; there are no unresolved threads or other reported findings. All readable required gates pass. The configured code-quality rule has no directly readable result; GitHub reports CLEAN, which will be rechecked together with promotion-triggered guards before any protected merge.

This stays a draft on the maintainer authorization requested through the private native channel. The complete-portfolio readback and final four-property deployment acceptance remain pending; neither the green source review nor independently observed repository values substitutes for that live workflow proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant