Skip to content

fix(vpa): verify cleanup against rendered policies - #5466

Merged
devantler merged 2 commits into
mainfrom
codex/vpa-rendered-cleanup-5408
Oct 28, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/vpa-rendered-cleanup-5408

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The orphan cleanup refuses correctly deployed lifecycle rules because their published formatting differs. This leaves an obsolete autoscaler producing repeated errors.

What

Checks deployment evidence in its published form before cleanup while retaining safeguards for live workloads and changed identities. Production cleanup and observed recovery remain acceptance steps.

Part of #5408

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

cr:no-gate@5f17d30 — CodeRabbit's freshly authenticated repository quota receipt applies until 22:59:41 UTC with margin. No CodeRabbit review or finding has been delivered at this head, and the no-gate guard admits this record. CI is settled green. Advancing once to Codex under this head's owned review lock.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T22:46:27.932526Z 5f17d30 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 5f17d30030

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 5f17d300305e43bb780782944d8203e17fb8c4e5: CI and all readable required checks/workflows pass. The configured native code-quality rule has no independently readable verdict; the protected merge API remains authoritative. Codex completed its current-head review without findings, and the complete discussion/review/thread reads contain no unresolved finding.

User evaluation exercised the cleanup command against the actual reviewed production render: the old implementation refused the correctly deployed generators, while this change accepts their complete rendered content. Failed, malformed, missing, duplicate or empty render controls still stop before cleanup, and changed live generators still refuse. The existing provenance, owner-retention, UID/version and deletion-race controls pass. A separate read-only production comparison confirms the rendered generators match deployment. Production cleanup and its recovery window remain explicit post-merge gates; this PR does not claim those outcomes.

The signed head is clean and mergeable, and the live-health gate passes. Promoting for the normal protected queue.

@devantler
devantler marked this pull request as ready for review October 27, 2026 22:52
@devantler
devantler added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 090c7be Oct 28, 2026
41 checks passed
@devantler
devantler deleted the codex/vpa-rendered-cleanup-5408 branch October 28, 2026 03:32
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant