Repository navigation
fix(vpa): verify cleanup against rendered policies - #5466
Conversation
cr:no-gate@5f17d30 — CodeRabbit's freshly authenticated repository quota receipt applies until 22:59:41 UTC with margin. No CodeRabbit review or finding has been delivered at this head, and the no-gate guard admits this record. CI is settled green. Advancing once to Codex under this head's owned review lock. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at User evaluation exercised the cleanup command against the actual reviewed production render: the old implementation refused the correctly deployed generators, while this change accepts their complete rendered content. Failed, malformed, missing, duplicate or empty render controls still stop before cleanup, and changed live generators still refuse. The existing provenance, owner-retention, UID/version and deletion-race controls pass. A separate read-only production comparison confirms the rendered generators match deployment. Production cleanup and its recovery window remain explicit post-merge gates; this PR does not claim those outcomes. The signed head is clean and mergeable, and the live-health gate passes. Promoting for the normal protected queue. |
Why
The orphan cleanup refuses correctly deployed lifecycle rules because their published formatting differs. This leaves an obsolete autoscaler producing repeated errors.
What
Checks deployment evidence in its published form before cleanup while retaining safeguards for live workloads and changed identities. Production cleanup and observed recovery remain acceptance steps.
Part of #5408