Repository navigation
fix: adopt verified release recovery writer checks - #5502
Conversation
Part of #4839. Pin the protected v14.0.2 engine, prove read-only refusal before minting the existing scoped writer, preserve consent and one-attempt publication, and cover the shipped probe with positive and failure controls.
Validation at
The real App-backed control and both historical recoveries are intentionally still pending the protected consumer merge. Existing App grants, writer scope, permanent confirmation, publication count and latest-release safeguards are unchanged. All five original #4839 acceptance criteria, including the unknown historical cause, remain open; the shared rollout also remains open in devantler-tech/.github#787 and #603. |
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 60c91a338d24e21d3985f554f63624c53b75faf9
- CodeRabbit: this PR's included-review refusal, provider event 2026-10-28 10:13:16 UTC, states 26 minutes until the next included review. Repository scope: Platform; recovery is approximately 10:39:16 UTC. Its separate command reply confirms the review did not run. The no-gate guard reports
ADMIT. - Codex: the account code-review usage refusal, provider event 2026-10-28 06:16:55 UTC, follows the authenticated
devantlerrequest and requires account credits/settings to resume. The artifact was freshly read; no newer serving evidence was found in the current health sweep. No redundant request or paid overage was used. The current-PR no-gate guard reportsADMIT. - Cursor Bugbot: the same-repository user/team usage refusal, provider event 2026-10-28 07:49:32 UTC, requires a user or team administrator to change the usage/spend limit. The artifact was freshly read; no newer serving evidence was found. The current-PR no-gate guard reports
ADMIT.
This is a separate fallback review round after the pre-submission self-review. I re-read the complete five-file diff against 82fcd45689c0207d58096c4ad05a0a716f2c48e4, checking correctness, security and the repository review guidelines. I checked the fixed public API target, bounded request/response handling, explicit refusal classification, response/credential privacy and cleanup, implicit step-failure propagation before the unchanged writer, immutable engine provenance, generated CI parity and required negative controls. No actionable correctness or security finding remains.
Direct current-PR reads show no external review artifact, unresolved thread or non-thread finding. Full native CI succeeded at this head. The real App-backed controls and historical publication outcomes remain separate rollout acceptance; this review does not claim them.
Verdict: no P0/P1 findings
Ready at User evaluation exercised the shipped read-only probe's refusal and failure cases and the actual immutable-engine download, declared Go 1.26.9 build and credential-free refusal. The complete native CI run executes the updated recovery contracts. Native App-backed controls and the historical recoveries remain post-merge acceptance in #4839 and devantler-tech/.github#787/#603; they are not inferred from offline controls. Fresh main is |
Why
The first recovery attempt stopped before publication because its engine could not verify the existing GitHub App credential. The missing releases still need a safe recovery path.
What
Adopt the released permission-check repair and verify that the read-only credential is refused before requesting a writer. Keep explicit consent and the existing recovery safeguards; live recovery and the historical cause investigation remain open.
Part of #4839