Skip to content

fix(kubescape): deploy timestamp-compatible summary repair - #5526

Merged
devantler merged 1 commit into
mainfrom
codex/storage-native-codec-adopt-v10-5419
Oct 29, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/storage-native-codec-adopt-v10-5419

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The deployed scan storage still rejects otherwise matching summaries because the stored formats preserve timestamps at different precision. This prevents reliable security-report coverage.

What

Deploys the published repair that compares those timestamps consistently while preserving the existing data and safety checks. Recovery remains subject to fresh production verification after deployment.

Part of #5419

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at bb62d403f24ff7f062a5b870bb823285dd99f094: the existing storage publication/pin contract, ShellCheck, local/prod manifest validation, pinned production-authorization renderer and authorization tests pass. The changed Kubescape layer is present in both manifest-validation outputs. Unrelated OCI chart render skips and offline namespace-label uncertainty remain limitations of the local checks.

Automatic publication 40733288164 completed successfully at reviewed main f90df920acce50d6af7a3df0f95a00c02639a173. Independent registry reads verified index sha256:09e5868c8a20a958587ec57755c3e447fb25f3d46945e4f0da40788fd3f5ec96, its Linux image and provenance subjects by digest; the source/platform revisions match. Cosign verified the exact main-only publisher identity, claims, transparency inclusion and certificate issuer.

Self-review found no correctness, security or simplification issues in this three-file adoption. Only the image pin, existing pin assertion and validator-reported HelmRelease approval move. Fresh production repair, paired API consistency, subsequent scanner updates and retained-volume acceptance are still required; #5419 stays open.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 17 minutes.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between f90df92 and bb62d40.

Files selected for processing: 3
  • k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml
  • scripts/tests/test-kubescape-storage-hotfix.sh
  • scripts/validate-eks-ci-role-policy/approved-surface.txt
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

CodeRabbit did not review bb62d403f24ff7f062a5b870bb823285dd99f094: its authenticated response at 17:34:37 UTC reports that the included review limit is reached, with the next included review in 17 minutes. Scope: this request/PR; recovery no earlier than 17:51:37 UTC, allowing for the rounded window. Its summary is a rate-limit shell. No paid review was requested.

Fresh current-head review census and the no-gate guard report no delivered CodeRabbit review (ADMIT). Advancing to the serving Codex lane.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T17:36:18.356979Z bb62d40 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The Codex request at bb62d403f24ff7f062a5b870bb823285dd99f094 remains acknowledged without a substantive review after more than 90 minutes. The preserved sample of 96 recent, head-matched completed reviews has a maximum request-to-verdict time of 197 seconds; a conservative 60-minute acknowledged window is over eighteen times that observed maximum. This request has exceeded that window.

Fresh conversation, review-object, thread and check-run reads retain no finding or successful review at this head; the no-gate guard reports ADMIT. This records a stalled request, not a portfolio-wide Codex outage. CodeRabbit's current included-review limit and Bugbot's freshly verified usage-limit response also prevent delivery, so the contract's local review round applies.

@devantler devantler left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: bb62d40

  • CodeRabbit: the authenticated 17:34 UTC request was refused by the included-review limit; a freshly read response on platform #5525 at 18:39 UTC confirms the same repository's continuing limit. Recovery follows included capacity becoming available; no paid review is authorized.
  • Codex: the 17:36 UTC request is still acknowledged without a substantive artifact after over 90 minutes, exceeding the conservative 60-minute acknowledged window derived from the preserved recent delivery sample. The current-head stall record retains the request and measurement. This is request-specific; Codex is serving other work. Recovery is a substantive artifact for this head.
  • Cursor Bugbot: the authenticated usage-limit response at 07:49 UTC was read again immediately before this round. It requires an administrator to restore service; no current-head Bugbot run or delivered review exists.

Direct conversation, review-object, inline-thread and check-run reads are complete at this head. No provider finding was discarded. Each no-gate guard admits this head.

I reviewed the complete three-file adoption diff for correctness, security and unnecessary complexity. The image index and Linux subject match the reviewed automatic producer and independently verified provenance and signature. The declared image and existing pin assertion agree. The one approval change comes from the pinned renderer and changes no authorization grant. The existing data-row identity/concurrency protections, volume retention, rollout strategy, scan selection and admission verification remain intact. All current-head CI checks are settled successfully or expectedly skipped. Local manifest-validation limitations are retained in the earlier validation receipt.

No inline findings. Production startup repair, paired API consistency, subsequent scanner updates and retained-volume acceptance remain required before issue #5419 can close.

Verdict: no P0/P1 findings

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at bb62d403f24ff7f062a5b870bb823285dd99f094: all current-head checks are settled, the required check is present and successful, there are no unresolved threads or non-thread findings, and the branch is mergeable against current main db46da4e3c71a26c7310775b0e9d4f4a5204425c. The current-head local review is posted and the reviewed verdict helper confirms GREEN self@bb62d403f24ff7f062a5b870bb823285dd99f094. Host ownership identifies this session only.

User evaluation for this declarative pin: I exercised the existing image/patch contract, the actual pinned authorization renderer and both local/prod manifest validators, inspected the successful reviewed automatic producer, and independently verified the published image, provenance and exact publisher signature. The known local render limitations remain in the validation receipt. The protected production trial will exercise the adoption; startup repair, paired API consistency, later scanner updates and volume retention still need fresh acceptance before #5419 closes.

The coarse live-health gate currently passes; that does not assert that all Coroot or Kubescape findings are resolved. Promoting this bounded adoption and entering the protected queue.

@devantler
devantler marked this pull request as ready for review October 28, 2026 19:10
@devantler
devantler added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 7451a1e Oct 29, 2026
51 checks passed
@devantler
devantler deleted the codex/storage-native-codec-adopt-v10-5419 branch October 29, 2026 02:01
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant