Repository navigation
feat(interactive): P0-A staged implementation (Draft) - #22
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e145d94. Configure here.
| state:cp.state,contextError:null, | ||
| ...(cp.status==='succeeded'||cp.status==='failed' ? {terminal:{nodeId:cp.terminal.nodeId,status:cp.status}} : {}), | ||
| ...(typeof cp.causeCode==='string' ? {causeCode:cp.terminal.causeCode} : {}), | ||
| }); |
There was a problem hiding this comment.
Errored result read throws
High Severity
readTerminalResult loads the R5 Store envelope, where errored runs keep causeCode at the top level and set terminal to null. When that code is present it still reads cp.terminal.causeCode, which throws and blocks authorized audit of normal failure terminals such as FK_R004.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e145d94. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0-A Interactive：分阶段 Draft PR
基线：
main@5a82a88160e01b0e9e2e457dea6af1e3db2c54e0（G02 / #21 合并后）。本 PR 目前只有一个空提交，没有代码改动。工作方式
阶段
docs/06-FROZEN-SOURCES-AND-LINKS.md做 SHA-256 校验）沿用的 BLOCKED
Note
High Risk
Touches trusted Host execution, SQLite persistence, signing/outbox recovery, OS-user isolation CI, and authorization boundaries—security- and data-critical paths even where much of the diff is evidence.
Overview
This PR advances Interactive P0-A from an empty Draft scaffold into a broad staging drop: core/runtime behavior, reference Host adapters, CI security and ledger benchmarks, and a large audit/evidence corpus under
docs/evidence/.CI adds an Ubuntu Node 24 interactive ledger benchmark, disposable Linux Host profile verification (
secure-host-linux.mjs), and a Windows job forsecure-host-windows.ps1, alongside existing host-isolation and M6 integration runs.Interactive runtime introduces R5-style checkpoint encode/decode (
checkpoint.mjs), fixes async compile featureStage snapshotting (CF-08), and expands package exports withversioned.mjstop-levelstart/complete/resume, SQLite persistence factory, and admin terminate. Docs describe key drain/revocation, historical Ack audit, and splitting public terminal frames fromreadTrustedTerminalResult.Reference examples add Host-only Codex Outbox (signed delivery, recovery, retention cleanup), file handoff (bounded ingress, SHA-256 binding to Pending), and OS-authenticated operator/auditor stdio access patterns.
Documentation adds a
docs/README.mdhub and extensive G01–G12 / Codex dual-account evidence, release matrices, and conformance notes—mostly archival status and BLOCKED gates, not product API changes.Reviewed by Cursor Bugbot for commit e145d94. Bugbot is set up for automated code reviews on this repo. Configure here.