Skip to content

chore: Rename DecodedArray to ArrayData - #136

Closed
kylebarron wants to merge 2 commits into
mainfrom
kyle/rename-decoded-array-to-data
Closed

chore: Rename DecodedArray to ArrayData#136
kylebarron wants to merge 2 commits into
mainfrom
kyle/rename-decoded-array-to-data

Conversation

@kylebarron

Copy link
Copy Markdown
Member

Rename DecodedArray to ArrayData to be more consistent in the naming across our codebase.

  • Array: a (usually) out of memory Zarr typed array
  • ArrayBytes: in-memory untyped bytes
  • ArrayData: in-memory typed array data

@d-v-b

d-v-b commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

also worth considering having "Array" mean "an accessor to the chunks" and "ChunkX" mean "An X-flavored chunk (of an array)", e.g. "ChunkBytes"

@kylebarron

Copy link
Copy Markdown
Member Author

I think we could probably spend a bunch of time talking about this, so perhaps better to let it sit in the back of our minds while we progress.

I think Chunk to me refers to something that is aligned with the Zarr chunk grid. This is in contrast to ArrayData which could represent any arbitrary array subset.


DecodedArray: TypeAlias = Tensor | VariableArray | MaskedTensor | MaskedVariableArray
"""The result of a read: one of the four decoded array layouts.
ArrayData: TypeAlias = Tensor | VariableArray | MaskedTensor | MaskedVariableArray

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps FixedLengthTensor and VariableLengthTensor?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use Optional instead of Masked?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tensor: TypeAlias = FixedLengthTensor | VariableLengthTensor ... ?

@kylebarron

Copy link
Copy Markdown
Member Author

Closing in favor of #172

@kylebarron kylebarron closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants