fix(deps): resolve pnpm audit failures in transitive dependencies#89
Open
riglar wants to merge 3 commits into
Open
fix(deps): resolve pnpm audit failures in transitive dependencies#89riglar wants to merge 3 commits into
riglar wants to merge 3 commits into
Conversation
- bump hono 4.12.26 -> 4.12.31 and fast-uri 3.1.2 -> 3.1.4 (lockfile only) - update brace-expansion overrides: the pins added for the previous advisory (1.1.13 / 5.0.6) are exactly the versions flagged by GHSA-3jxr-9vmj-r5cp; now pin 1.1.16 / 5.0.7 - ignore GHSA-frvp-7c67-39w9 (@hono/node-server serve-static path traversal on Windows): the fix is a major (2.0.5) outside the MCP SDK's ^1.19.9 range, and dcd-mcp is stdio-only and never serves static files. Remove the exemption when the SDK adopts 2.x. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…error Debug commit — will be reverted once the failure cause is captured. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… hidden error" This reverts commit c61643d.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's
pnpm audit --audit-level moderategate is failing on every PR (8 vulnerabilities: 4 high, 4 moderate), all in transitive dependencies. This clears the audit:hono4.12.26 → 4.12.31,fast-uri3.1.2 → 3.1.4 (under@modelcontextprotocol/sdk) — patched versions fit the parents' semver ranges, so this is a lockfile-only update; no dependency specs changed.brace-expansion(GHSA-3jxr-9vmj-r5cp) — the existingpnpm.overrides, added for a previous brace-expansion advisory, were pinning 1.1.13 / 5.0.6, which are exactly the versions the new advisory flags. Overrides updated to 1.1.16 / 5.0.7 (and the 4.x range widened to>=3.0.0to match the advisory).@hono/node-server(GHSA-frvp-7c67-39w9) — not fixable by updating: the patch is in 2.0.5 (a major), and the MCP SDK — even at its latest release — pins^1.19.9. Added apnpm.auditConfig.ignoreGhsasexemption for this single advisory rather than force-overriding a major into the SDK. The vulnerability is path traversal inserve-staticover HTTP on Windows;dcd-mcpis stdio-only and never serves static files, so the vulnerable path is unreachable. Remove the exemption once the SDK adopts@hono/node-server2.x.pnpm audit --audit-level moderatenow exits 0 (the one remaining moderate is the explicitly ignored GHSA).Test plan
pnpm audit --audit-level moderateexits 0pnpm typecheck,pnpm lint,pnpm buildpass locally🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.