Repository navigation
Merged
Conversation
Harness-Claim: true Agent: switchboard-dev Host: ANCHOR Base-Ref: origin/main Base-SHA: 2ee840b Claimed-At: 2026-11-09T13:30:01.9319593Z Nonce: 6005672f4bb1804d
…ows cell (#1029) Move the pure FILETIME helper out of cli-session-state so worker-liveness callers no longer reach its process probes, and let a helper's processes, filesystem, conpty and links markers select the tests that reach it. platform and winpath markers still do not propagate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1029.
Pure FILETIME helper split out.
procStartMatches,toCreatedand the FILETIME constants move fromcli-session-state.jstosrc/main/cli/proc-start.js, a module with no imports, no I/O and no platform branch.cli-session-state.jsre-exports them, so its consumers are unchanged.bg-worker-liveness.jsnow imports the pure module, and the worker-liveness tests no longer reach the module's process probes.remote-ssh-binary.jsis left as is.remote-attach.jsusesresolveSshPath, which really is platform behaviour (.exehandling, PATH delimiters, OpenSSH and Git install paths), so its callers stay selected.Rule C propagation. In
scripts/platform-tests.js, a helper'sprocesses,filesystem,conptyandlinksmarkers now select every test that reaches it transitively.platformandwinpathstill do not propagate, since dom-setup alone would pull about 97 jsdom tests. The 150-file floor and the// platform: windowsopt-ins are unchanged.Effect on the Windows cell. 379 → 387 of 570 files.
read-session-file(filesystem) and spawning helpers.bg-stale-activity-767,bg-worker-liveness,canary-bg-agents-files(it already skips on CI runners),dom-sidebar-bg-activity-628andgreen-dot-pty-here-714. All five stay in the Linux job, whose coverage run executes the whole inventory.Known over-selection, kept on purpose. A required
.jsonfile is scanned for markers too, so a test requiringpackage.jsonis selected throughconptybecause the file mentionsnode-pty. Propagation also starts from production dependencies, not only test helpers. Both only add tests to the Windows cell; neither can drop one.Tests.
test/platform-test-selection.test.jsgains one fixture per propagating marker, a negative platform/winpath fixture and a cycle fixture.bg-worker-livenessis asserted not to reach the platform probes. Each new case was shown failing before the change, and three named mutations are caught. Locally: platform-test-selection 38/38, bg-worker-liveness 20/20, module-layout 7/7.