Skip to content

(ci): stop cli-session-state from pulling generic tests into the Windows cell (#1029) - #1042

Merged
devsuitup merged 3 commits into
mainfrom
wt/1029
Nov 9, 2026
Merged

devsuitup merged 3 commits into
mainfrom
wt/1029

Conversation

@devsuitup

Copy link
Copy Markdown
Owner

Closes #1029.

Pure FILETIME helper split out. procStartMatches, toCreated and the FILETIME constants move from cli-session-state.js to src/main/cli/proc-start.js, a module with no imports, no I/O and no platform branch. cli-session-state.js re-exports them, so its consumers are unchanged. bg-worker-liveness.js now imports the pure module, and the worker-liveness tests no longer reach the module's process probes.

remote-ssh-binary.js is left as is. remote-attach.js uses resolveSshPath, which really is platform behaviour (.exe handling, PATH delimiters, OpenSSH and Git install paths), so its callers stay selected.

Rule C propagation. In scripts/platform-tests.js, a helper's processes, filesystem, conpty and links markers now select every test that reaches it transitively. platform and winpath still do not propagate, since dom-setup alone would pull about 97 jsdom tests. The 150-file floor and the // platform: windows opt-ins are unchanged.

Effect on the Windows cell. 379 → 387 of 570 files.

  • 38 sole-contributor selections removed by the split.
  • 33 of them brought back by propagation, plus 13 others, mostly read-session-file (filesystem) and spawning helpers.
  • 5 files leave for good: bg-stale-activity-767, bg-worker-liveness, canary-bg-agents-files (it already skips on CI runners), dom-sidebar-bg-activity-628 and green-dot-pty-here-714. All five stay in the Linux job, whose coverage run executes the whole inventory.

Known over-selection, kept on purpose. A required .json file is scanned for markers too, so a test requiring package.json is selected through conpty because the file mentions node-pty. Propagation also starts from production dependencies, not only test helpers. Both only add tests to the Windows cell; neither can drop one.

Tests. test/platform-test-selection.test.js gains one fixture per propagating marker, a negative platform/winpath fixture and a cycle fixture. bg-worker-liveness is asserted not to reach the platform probes. Each new case was shown failing before the change, and three named mutations are caught. Locally: platform-test-selection 38/38, bg-worker-liveness 20/20, module-layout 7/7.

Harness-Claim: true
Agent: switchboard-dev
Host: ANCHOR
Base-Ref: origin/main
Base-SHA: 2ee840b
Claimed-At: 2026-11-09T13:30:01.9319593Z
Nonce: 6005672f4bb1804d
…ows cell (#1029)

Move the pure FILETIME helper out of cli-session-state so worker-liveness callers no longer reach its process probes, and let a helper's processes, filesystem, conpty and links markers select the tests that reach it. platform and winpath markers still do not propagate.
@devsuitup devsuitup added the no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived label Nov 9, 2026
@devsuitup
devsuitup merged commit 4cdcad3 into main Nov 9, 2026
10 checks passed
@devsuitup
devsuitup deleted the wt/1029 branch November 9, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(ci): stop cli-session-state from pulling generic tests into the Windows cell

1 participant