Skip to content

(release): pin the publish script to the repository it reads (#1087) - #1088

Merged
devsuitup merged 5 commits into
mainfrom
wt/1087
Nov 11, 2026
Merged

devsuitup merged 5 commits into
mainfrom
wt/1087

Conversation

@devsuitup

Copy link
Copy Markdown
Owner

Fixes #1087.

scripts/publish-release.sh read the releases of GITHUB_REPOSITORY but created the draft and uploaded assets with bare gh, which uses gh's default repository. Run by hand in a clone whose default is upstream (the fallback docs/releasing.md describes when macOS never builds), the create went to doctly/switchboard on 2026-11-11; it was refused only because the tag was absent there.

  • Every gh call passes --repo "${GITHUB_REPOSITORY}"; the script refuses before any gh call when GITHUB_REPOSITORY or GITHUB_REF_NAME is empty.
  • test/publish-release.test.js covers both.
  • docs/releasing.md spells out the hand-made draft: download the tag run's artifacts, keep the x64 pacman (both Linux jobs produce the same file name), run the script with the two variables and DIST_DIR, attach the notes, check the assets — and states that every gh command run by hand here needs --repo devsuitup/switchboard.

Harness-Claim: true
Agent: codex
Host: ANCHOR
Base-Ref: origin/main
Base-SHA: e094276
Claimed-At: 2026-11-11T18:35:20.2463206Z
Nonce: 4711d31894df1192
Run by hand in a clone whose gh default is upstream, the draft was created against doctly/switchboard. Every gh call now names GITHUB_REPOSITORY, the script refuses to run without it, and the macOS-missing fallback is spelled out.
@devsuitup devsuitup added the no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived label Nov 11, 2026
@devsuitup
devsuitup merged commit b197b85 into main Nov 11, 2026
15 of 16 checks passed
@devsuitup
devsuitup deleted the wt/1087 branch November 11, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(release): the publish script can create a release on the upstream repository when run by hand

1 participant