Repository navigation
(terminals): assign a job to live tabs once the Windows job helper is ready - #1159
Merged
Merged
Conversation
… is ready Tabs whose job assignment failed during a slow start are now assigned once when a later helper start succeeds, the backoff expiry retries on its own, and the backoff uses a monotonic clock.
…it is being stopped A project-delete stop waiting on the first assignment no longer keeps the tab out of recovery, and the close/release/observe guard is tested again after the backoff expires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1156
Follow-up of #1140 (#1154). Tabs restored during a slow cold start all joined the first Windows job helper start and failed at 15 s; they kept the plain ConPTY close for life, so children they spawned later outlived the tab (#1015).
.ai/contexts/ipc-bridge.md.Tests:
test/windows-job-recovery.test.js(new, stubbed helper) andtest/windows-job-helper.test.js, red on main first.