Repository navigation
(session-index): bound writer command deadlines by the work a folder write carries - #1166
Merged
Merged
Conversation
…er write carries Effects, certificate and name-derivation commands get a deadline that scales with their serialized payload and entry count, so a large folder finishes on a busy machine, and a retry after an unknown outcome reuses rows that are already durably committed.
…scaled deadline The deadline estimate no longer serializes the payload on the main thread, the scaled deadline is capped at ten minutes, and the resume guards (deletion on a full retry, durable witness, source stamp) are tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1135
Under load the cold scan of the largest project folder never completed: its folder write timed out (
writer command timed out … outcome unknown), the whole folder restarted, and the initial scan never finished.effects,certifyFullReadsandderiveCachedNameswriter commands now scale with the work they carry: the 30 s base is multiplied by the larger of the 32 KiB serialized-payload blocks and the 32-entry blocks (nested arrays included). Other commands and transaction packing are unchanged.Tests:
test/session-index-large-folder-1135.test.js(stubbed slow writer on a large synthetic folder, a few rows with a large text, and an unknown-outcome batch), red on main first.