Repository navigation
(e2e): measure the E4 header layout in one snapshot - #1169
Merged
Merged
Conversation
…il it settles The five boxes were read in separate calls while the shell could still replace the synthetic PTY title; the journey now reads them together and retries a bounded number of times, keeping the 24 px limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1163
E4 read five bounding boxes in separate
boundingBox()calls (CDPDOM.getBoxModel), which do not come from one layout. The trace of the failing run (44847551734, attempt 1) shows that right after the 800→1400 resize the id box came from a layout without E4's labels and the Refresh box from one with them (~95 px apart), although the DOM held the labels at both reads..ai/contexts/tool-bar.mdnotes the rule.Test-only change: no changelog entry. CI e2e is the gate (Playwright does not run on the workstation).