Skip to content

(e2e): measure the E4 header layout in one snapshot - #1169

Merged
devsuitup merged 2 commits into
mainfrom
fix/1163-e2e-e4-settled-layout
Nov 21, 2026
Merged

devsuitup merged 2 commits into
mainfrom
fix/1163-e2e-e4-settled-layout

Conversation

@devsuitup

@devsuitup devsuitup commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Closes #1163

E4 read five bounding boxes in separate boundingBox() calls (CDP DOM.getBoxModel), which do not come from one layout. The trace of the failing run (44847551734, attempt 1) shows that right after the 800→1400 resize the id box came from a layout without E4's labels and the Refresh box from one with them (~95 px apart), although the DOM held the labels at both reads.

  • The journey measures id, info, Refresh, Stop and the header in one page evaluation and retries a bounded number of times until the layout is consistent.
  • The 24 px bound is unchanged. .ai/contexts/tool-bar.md notes the rule.

Test-only change: no changelog entry. CI e2e is the gate (Playwright does not run on the workstation).

…il it settles

The five boxes were read in separate calls while the shell could still
replace the synthetic PTY title; the journey now reads them together and
retries a bounded number of times, keeping the 24 px limit.
@devsuitup devsuitup added the no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived label Nov 21, 2026
@devsuitup
devsuitup merged commit 01a324a into main Nov 21, 2026
6 checks passed
@devsuitup
devsuitup deleted the fix/1163-e2e-e4-settled-layout branch November 21, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog The PR changes nothing a user sees; the CHANGELOG.md check is waived

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(e2e): E4 tool-bar journey intermittently measures Refresh 100 px away from the id

1 participant