You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(release): harden provider upload and standardize prek tooling - #94
Replace softprops/action-gh-release with gh release upload --clobber. Its update-release PATCH failed for SSH v1.1.43, leaving Latest without provider.yaml and causing downstream 404s.
Standardize hooks on prek.toml with versioned tools in mise.toml/mise.lock, exact project Go versions for Go hooks, and jdx/mise-action in CI.
Remove Taskfile.yml and preserve all prior tasks in mise.toml.
Verification: prek validate-config and actionlint pass. Every migrated task is listed by mise tasks; representative lint, test, argument-bearing, and download task definitions were exercised. The exact release-upload command succeeded against SSH v1.1.43.
Reviewing files that changed from the base of the PR and between 8738a07 and 6e6247c.
⛔ Files ignored due to path filters: 1
mise.lock is excluded by !**/*.lock
📒 Files selected for processing: 5
.github/workflows/pre-commit.yml
.pre-commit-config.yaml
Taskfile.yml
mise.toml
prek.toml
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 666bfe84-bbf6-4c89-82ea-2ff84fc42ed7
📥 Commits
Reviewing files that changed from the base of the PR and between c0ecced and 8738a07.
📒 Files selected for processing: 2
.github/workflows/pre-commit.yml
.pre-commit-config.yaml
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The release workflow now uploads provider.yaml with gh release upload. The pre-commit workflow sets up Go from go.mod, and Go hooks use the system Go installation by default.
The workflow uploads provider.yaml to the GoReleaser tag with gh release upload --clobber and GITHUB_TOKEN. This replaces the softprops/action-gh-release step.
Pre-commit Go setup
Layer / File(s)
Summary
Configure Go for hooks .github/workflows/pre-commit.yml, .pre-commit-config.yaml
The workflow sets up Go from go.mod before running prek. The pre-commit configuration selects the system Go installation as the default Go hook language version.
The release workflow uploads the provider asset to the intended release, and pre-commit uses the Go version declared by the module. No material merge risk remains.
Security architecture risk:🔵 Low · up to 8738a
Release publication retains the same token permissions, target tag, and asset. Replacement can still leave the asset missing after failure; that behavior predates this PR. Equivalence of retry and concurrent-run recovery behavior remains uncertain.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The publication credential retains repository contents-write authority, which is broader than this single asset. The new command names only dist/provider.yaml and does not introduce a different repository target or an additional credential scope.
Trust Boundaries and Controls
observed — Pull-request pre-commit execution remains in a separate workflow with contents: read. Adding Go setup does not change its trigger to a privileged pull-request context or give it the release workflow's write permission.
Pre-merge checks: 5
Check name
Status
Explanation
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly summarizes the main changes: hardening the release upload and standardizing prek tooling.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
skevetter
changed the title
ci(release): upload provider.yaml with gh release upload
ci(release): harden provider upload and standardize prek tooling
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three provider CI/tooling updates:
softprops/action-gh-releasewithgh release upload --clobber. Its update-release PATCH failed for SSH v1.1.43, leaving Latest withoutprovider.yamland causing downstream 404s.prek.tomlwith versioned tools inmise.toml/mise.lock, exact project Go versions for Go hooks, andjdx/mise-actionin CI.Taskfile.ymland preserve all prior tasks inmise.toml.Verification:
prek validate-configand actionlint pass. Every migrated task is listed bymise tasks; representative lint, test, argument-bearing, and download task definitions were exercised. The exact release-upload command succeeded against SSH v1.1.43.