Repository navigation
fix: reclaim runner disk and verify release publication - #157
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
@greptileai review |
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryThis PR repairs release builds and adds checks for published assets.
No actionable issues were found. The review checked source and configuration; it did not independently rerun builds or backfills.
|
Ubuntu 26.04 makes /tmp a RAM-backed filesystem with a roughly 8 GiB quota. SSH v1.1.45 and v1.1.46 failed cross-compilation with disk-quota errors and were left with no release assets. Cleaning the runner freed 17 GiB but reproduced the error because /tmp has a separate limit.
Use GOTMPDIR=$RUNNER_TEMP for disk-backed Go build temporary files. Start free-disk-space in the background during setup and wait before compiling. Preserve parallel GoReleaser builds, artifact names, existing tags, and the five-platform binary set.
Add manual tag-specific backfills and a Go verifier at hack/verify-release/main.go. Fail publication unless all five binaries, checksums.txt, and provider.yaml are present and nonempty. Download every required asset, verify binary SHA-256 sums and the complete checksum platform set, and compare the published manifest and checksum file against build outputs.
Validation: Go verifier race tests and all prek hooks passed, including Go lint. Regression tests reject missing/empty/duplicate assets, corrupt or missing binaries, stale metadata, incomplete or duplicate checksum sets, and malformed digests. Local CodeRabbit tag-validation/selection findings addressed. Both v1.1.45 and v1.1.46 backfills succeeded with all seven assets downloaded and verified by the Go verifier. Final head a68ebb6 has all CI green, including Linux integration and the Windows rerun. Greptile 5/5, completed CodeRabbit review with no actionable findings, no unresolved review threads, and verified commit signatures.
Actionlint v1.7.12 predates GitHub background/wait support. Compatibility exclusions cover its obsolete parser diagnostics; GitHub validates actual workflow syntax. Azure has the same confirmed release defect and equivalent repair in devsy-org/devsy-provider-azure#118.
Successful backfills: https://github.com/devsy-org/devsy-provider-ssh/actions/runs/39619810633 and https://github.com/devsy-org/devsy-provider-ssh/actions/runs/39619841717