Repository navigation
test(e2e): pin Compose shutdown sidecars to Devsy GHCR - #1450
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The two shutdown test sidecars now use the pinned image; no production behavior changes are indicated. Targeted checks are reported passing, while the broader failures reportedly also occur on the base and do not establish a new blocker, though the stated validation workflow remains unfinished. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@coderabbitai full review @greptileai please review this pull request at current head 8165397. This is a review request only; the PR remains draft pending validation and review completion. |
✅ Action performedFull review finished. |
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
The two Compose shutdown fixtures currently pull
alpine:latestfrom Docker Hub solely to keep a sidecar running withsleep infinity. Pin those two sidecars to the existing public Devsy Alpine base atsha256:fbd195076b0c5d37580debed78de5e4dd238436cd5aa348339a4d48463ff71ae.This is role-specific reuse of a richer Alpine 3.23 Dev Container image. Anonymous source/candidate pulls and Compose checks on Linux arm64 and amd64 verified root runtime user, working directory
/, PID 1sleep, temporary-file access, and unchanged stop behavior. The app images, commands, mounts, shutdown configuration, test bodies and timeouts are unchanged. No image publication is needed for this slice.Closes #1451.
Parent migration tracker: #1449 remains open for verified bare runtime mirrors, service-image mirrors and the later inventory guard.
Validation:
task cli:lint:cireports zero issues.up-docker-composelabel: 49 passed, 6 failed in 798.527 seconds. All three changed-fixture cases pass in this full run too; a read-only observer verified both pinned shutdown sidecars running before stop. Failures: two UID-mapping checks reproduced with unchanged main fixtures; three macOS Feature-copylchown: operation not permittederrors reproduced separately with unchanged fixtures; and the unchanged multistage build after Debian HTTP package-download failures exhausted the configured retries. All six failure identities reproduce against unchanged main56485803a98ccbf0505b1b42b8ecc12629ccfaf9. The package case also fails on its single bounded rerun with existing retries and sources unchanged. These historical baseline failures were subsequently audited separately from this two-image-reference change.81653971450e7021b1fc3c1469dcc950b70e5fc6verifies locally and on GitHub (verified: true,reason: valid).Current validation and readiness:
Summary by CodeRabbit