Skip to content

Show loading progress during server connection and sign-in - #116

Merged
dfederm merged 1 commit into
mainfrom
dfederm/jellybox-server-login-loading-indicator
Sep 16, 2026
Merged

dfederm merged 1 commit into
mainfrom
dfederm/jellybox-server-login-loading-indicator

Conversation

@dfederm

@dfederm dfederm commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

Adds visible progress feedback while JellyBox validates a server connection or performs
username/password sign-in. The existing LoadingOverlay is bound to
ConnectCommand.IsRunning on Server Selection and SignInCommand.IsRunning on Login, reusing the
current busy-state sources without changing interaction behavior.

Quick Connect intentionally remains unchanged because its dialog displays an actionable
authorization code while waiting for user input.

Why this is safe

  • Limited to two XAML views and the existing LoadingOverlay control.
  • Reuses command IsRunning state; no authentication or connection logic changes.
  • Existing IsInteractable enablement bindings remain unchanged.
  • The generated Login binding maps SignInCommand.IsRunning directly from Boolean to
    Visibility.

Validation

Test / build Result
Debug x64 solution build Passed with 0 warnings and 0 errors
Automated tests No automated test project exists in the repository

@dfederm
dfederm merged commit d740da0 into main Sep 16, 2026
1 check passed
@dfederm
dfederm deleted the dfederm/jellybox-server-login-loading-indicator branch September 16, 2026 04:14
@dfederm
dfederm restored the dfederm/jellybox-server-login-loading-indicator branch September 16, 2026 04:15
@dfederm
dfederm deleted the dfederm/jellybox-server-login-loading-indicator branch September 16, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant