Repository navigation
Show loading progress during server connection and sign-in - #116
Merged
Merged
Conversation
dfederm
restored the
dfederm/jellybox-server-login-loading-indicator
branch
September 16, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds visible progress feedback while JellyBox validates a server connection or performs
username/password sign-in. The existing
LoadingOverlayis bound toConnectCommand.IsRunningon Server Selection andSignInCommand.IsRunningon Login, reusing thecurrent busy-state sources without changing interaction behavior.
Quick Connect intentionally remains unchanged because its dialog displays an actionable
authorization code while waiting for user input.
Why this is safe
LoadingOverlaycontrol.IsRunningstate; no authentication or connection logic changes.IsInteractableenablement bindings remain unchanged.SignInCommand.IsRunningdirectly fromBooleantoVisibility.Validation