Repository navigation
Keep display awake during native video playback - #118
Merged
Merged
Conversation
Hold a UWP display request while video opens, buffers, or plays. Release it while paused and after completion, failure, or navigation away, with ownership guards for queued media callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Prevents Windows/Xbox from dimming or sleeping during active native JellyBox/Jellyfin video and local trailer playback by holding a UWP
DisplayRequestwhile playback is opening, buffering, or playing. The request is released while paused, on completion or failure, and when navigating away; request failures are logged without stopping video. No UI layout or control changes.Related issue: N/A (none identified).
Type of change
Checklist
together unrelated changes.
msbuild JellyBox.sln -t:Build -p:Configuration=Debug -p:Platform=x64succeeds with 0 warnings and 0 errors.
and playback behavior can't be reviewed from the diff alone).
on (real Xbox strongly preferred, Windows acceptable) — for any UI,
playback, or controller change.
Manual test notes
Manual playback and device-inactivity testing has not been performed. This PR remains a draft pending Windows or Xbox testing; no team review has been requested. Before requesting review, check native Jellyfin video and local trailers during opening, buffering, and playing, then verify that normal inactivity resumes on pause, completion, failure, and navigation away. Include track restarts, repeated cycles, and background/foreground transitions.
Validation performed on this commit:
& 'C:\Program Files\Microsoft Visual Studio\18\Enterprise\MSBuild\Current\Bin\MSBuild.exe' JellyBox.sln -t:Build -p:Configuration=Debug -p:Platform=x64 -verbosity:minimal -nologo— passed; 0 warnings and 0 errors.git diff --check d740da07c87a734425d0101fe861960650b5ac7f HEAD— passed; no whitespace errors.Screenshots / recording
No screenshots or recording attached. There are no visual layout changes; playback and device-inactivity behavior still need device testing.
Out of scope / follow-ups
WebView trailers, HDMI and system-suspension behavior, and unrelated player hardening are out of scope.