fix: skipping engines for determining starting versions - #11328
Merged
Conversation
basvandijk
approved these changes
Aug 26, 2026
basvandijk
had a problem deploying
to
PUSH_TO_RC_BRANCH
August 26, 2026 10:09 — with 
GitHub Actions
Failure
GitHub Actions
Failure
basvandijk
had a problem deploying
to
upload-artifacts
August 26, 2026 10:11 — with
GitHub Actions
Failure
GitHub Actions
Failure
basvandijk
had a problem deploying
to
upload-artifacts
August 26, 2026 10:16 — with
GitHub Actions
Failure
GitHub Actions
Failure
basvandijk
had a problem deploying
to
upload-artifacts
August 26, 2026 11:33 — with
GitHub Actions
Failure
GitHub Actions
Failure
basvandijk
had a problem deploying
to
upload-artifacts
August 26, 2026 11:33 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this script was introduced we didn't have:
Recently we added a concept of
StandardReplicaVersionwhich is meant to tell cloud engines what their version should be. GenerallyStandardReplicaVersionwill follow NNS meaning that cloud engines will at the end of the rollout all be on the same version as NNS.Opting out of the
StandardReplicaVersionhas a lot of potential issues and we still need to figure them out.