feat(cketh): skip sweeper requests when no sweeper contract is configured - #11352
Draft
gregorydemay wants to merge 2 commits into
Draft
feat(cketh): skip sweeper requests when no sweeper contract is configured#11352gregorydemay wants to merge 2 commits into
gregorydemay wants to merge 2 commits into
Conversation
…ured Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an early exit when no Ethereum sweeper contract is configured.
Changes:
- Checks sweeper configuration before creating requests.
- Adds no-op coverage and consolidates runtime mock creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sweep/mod.rs |
Skips request creation without a configured contract. |
sweep/tests.rs |
Tests no-op behavior and reuses a mock helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Groups the queued deposits into one batch per token, capped at ten deposits each, and resolves the attestation request every deposit in a batch will need. Nothing is signed or enqueued yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬