Pane-header right-click menu: bound ports, click to connect

[nedtwigg]

Right-clicking a terminal pane header opens one context menu showing the pane's
stable surface:N handle and the TCP ports its process tree binds. Clicking a
port row reproduces dor ab open <url> against the default agent-browser
session — the browser pane appears in the same tick and connects in the
background.

What's here

• One menu per header. The title span no longer owns its own right-click;
  only the alert bell does. The diagnostic title-candidates popover became a
  title candidates item at the bottom of the menu, still anchored to the title
  span.
• Instant connect. The click is fire-and-forget: the menu closes and the pane
  is created synchronously, before agent-browser open runs (a cold daemon boot
  is 1–3s). The eager pane is created without a session on purpose — a
  session-less ab-screencast pane is inert, so the controller's stale-port
  recovery cannot race the daemon boot. Once open succeeds the pane receives
  {session, wsPort, binaryPath} as one params refresh, and setting session is
  what connects it.
• The click reveals its surface. Unlike dor ab (focus-neutral, because an
  agent must not steal focus), a menu click is a human asking to see that
  browser: every eager-lookup arm ends by selecting the surface, reattaching it
  first if minimized. Selection only — passthrough stays on the terminal that was
  right-clicked.
• Port→URL selection is shared with surface.resolveOpen, so the menu and
  the CLI can't drift: one openable URL per distinct port, loopback wins
  localhost, IPv6 bracketed.
• Rows render as inert labels on hosts that can't run agent-browser (e.g. the web
  demo).

Two fixes found while dogfooding

A 3s freeze on connect that wasn't in the connect path. Timing showed the
surface created at 1.0ms but nothing painting until the command settled at
2888ms. agent_browser_command was a plain #[tauri::command], which Tauri runs
on the main thread, and its body blocks on recv_timeout until the sidecar
answers — so the webview couldn't paint for the whole daemon boot. The twelve
commands that reach the blocking sidecar helpers are now (async), which moves
the same body onto a runtime worker. This also fixes a class of smaller freezes,
including pty_get_open_ports, whose 3s budget could freeze the very
"scanning ports…" spinner that covers it. The invariant is stated at the helpers
themselves and in the standalone spec.

The eager pane's placeholder read Waiting for browser session — run dor ab open <url>: an empty session name plus instructions to redo the click that
created it. Session-less panes now show Connecting to browser session….

Testing

pnpm test green (spec-lint + all packages, 1102 lib tests), cargo check
clean. New unit tests cover the port→URL grouping, the connect sequencing
(including the failure arms), and the menu's states — scanning, loaded, empty,
scan-failed, inert-label, dismissal, and both title-candidates paths.

Verified live in standalone: click→pane is immediate, the app stays responsive
during the daemon boot, repeat clicks reuse and select the existing browser.

Known gap: revealSurface has no test — there is no hook-level test file for
use-dor-control, and connect-port.test.ts stubs ensureEagerSurface
wholesale, so the three eager arms aren't exercised. Building that harness is a
follow-up.

🤖 Generated with Claude Code

[cloudflare-workers-and-pages]

Deploying mouseterm with    Cloudflare Pages

Latest commit:	0e750de
Status:	✅  Deploy successful!
Preview URL:	https://11c418b3.mouseterm.pages.dev
Branch Preview URL:	https://right-click-to-connect.mouseterm.pages.dev

View logs

[dormouse-bot]

Nice feature — the eager session-less pane + one-shot params reconcile is a clean way to hide the daemon-boot latency, and the port-URL selection reuse plus the shared useDismissOverlay / POPUP_SURFACE_CLASS extractions are good de-duplication. One blocker, all one root cause.

dor-lib-common/agent-browser isn't resolvable in the bundling jobs (3 red checks)

connect-port.ts adds import { sessionForKey } from 'dor-lib-common/agent-browser', and connect-port is now reachable from the webview Wall graph (Wall → useDorControl → connect-port). That makes dor-lib-common the first package pulled into the webview bundle/typecheck through its package exports, which resolve to a ./dist/ that these jobs never build:

• Standalone Smoketest — connect-port.ts(19,31): error TS2307: Cannot find module 'dor-lib-common/agent-browser'. The job runs pnpm install + tsc --noEmit with no dor-lib-common build, and there's no paths mapping for it.
• Visual Regression — Rolldown failed to resolve import "dor-lib-common/agent-browser" while building Storybook.
• Cloudflare Pages — same website build, same unresolved import.

Build & Test is green only because pnpm -r run test builds dor-lib-common's dist (its test script runs build first, in topo order) before the lib typechecks — the other three jobs skip that step.

This is exactly the server-lib-common situation, which is already handled by aliasing the bare specifier to source in every bundler config and mapping it in tsconfig paths (its exports also "resolve to a dist this build never compiles"). dor-lib-common just needs the same treatment. A single directory alias covers both the . and /agent-browser subpaths:

• website/vite.config.ts — add alongside server-lib-common:
  "dor-lib-common": path.resolve(__dirname, "../dor-lib-common/src")
• lib/.storybook/main.ts (viteFinal alias block) — add:
  'dor-lib-common': path.resolve(here, '..', '..', 'dor-lib-common', 'src')
• standalone/tsconfig.json (paths) — add:
  "dor-lib-common": ["../dor-lib-common/src/index.ts"] and
  "dor-lib-common/agent-browser": ["../dor-lib-common/src/agent-browser.ts"]

For consistency (and so pnpm --filter dormouse-lib test / the Pocket bundle don't rely on a pre-built dist), the same alias is worth adding to lib/vite.pocket.config.ts and lib/vite.config.ts too — both already alias dor / server-lib-common for the same reason.

Want me to push this as a fix commit? It's mechanical and follows the existing server-lib-common alias pattern exactly.