Skip to content

Fix character controller manifold collection - #1004

Open
KaiStevenson wants to merge 1 commit into
dimforge:masterfrom
KaiStevenson:kai/fix-character-controller-manifold-collection
Open

Fix character controller manifold collection#1004
KaiStevenson wants to merge 1 commit into
dimforge:masterfrom
KaiStevenson:kai/fix-character-controller-manifold-collection

Conversation

@KaiStevenson

@KaiStevenson KaiStevenson commented Sep 4, 2026

Copy link
Copy Markdown

Fixes an issue in which character controller collisions with multiple colliders, at least one of which is compound, cause a panic.

Parry query dispatcher contact_manifolds can mem::take or otherwise reorder or remove colliders from the manifolds arg. The code in the character controller assumed it was append only--in these cases it could cause incorrect computation, or in cases with a composite collider, a panic.

Fix by building a new array for each call.

Fable 5.1 was used for regression test only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant