Make DTypes sealed traits - #149
Merged
Merged
Conversation
benikm91
force-pushed
the
make-dtype-sealed
branch
from
August 16, 2026 11:33
4f65a3e to
4048b0e
Compare
marcelluethi
self-requested a review
August 16, 2026 11:40
marcelluethi
approved these changes
Aug 16, 2026
marcelluethi
left a comment
marcelluethi
left a comment
Contributor
There was a problem hiding this comment.
Nice - simple fix with great effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making trait sealed makes VSCode show types better. Also it makes sense to make them not extendable.
After PR:
Before:
