Add missing, basic bool operations - #154
Open
benikm91 wants to merge 1 commit into
Open
Conversation
marcelluethi
approved these changes
Aug 21, 2026
marcelluethi
left a comment
Contributor
There was a problem hiding this comment.
I like the syntax for both the logical operations and the broadcasting.
Let's try it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing basic Boolean operations. However, we must decide how to do this. I propose that there must be exactly one way to do it, so we must pick one of the following:
Why not Alternative A: I think
andis an operator, so infix seems correct to me.Why not Alternative B:
&&means short-circuiting, which is wrong in tensorland.Why not Alternative C:
&valid alternative for me. I like "and" just betterWhy not Alternative D:
+is not that clear; e.g., true + true could also be false to me (finite space).Broadcasting would look like this; note
and!is impossible due to Scala syntax constraints:Here is an overview of the PR and Alternative C for all boolean operations (broadcasted):
Note: I see the
_!not as a disadvantage, as I envision similar broadcasting for e.g.wherein the future:But this will be a separate PR, let's not discuss
wherehere.