Repository navigation
fix(runtime): download the pinned archives from the nightly release - #38
Merged
Merged
Conversation
Dimoshka
added a commit
that referenced
this pull request
Nov 11, 2026
…ag + pin) Integrates the runtime archive fix and the build-script commit check from PR #38 after it merged into main. Conflicts resolved: - runtime_release.dart: keep RuntimeRelease.releases/forTag from this branch and assetTag on every asset from main. tag stays v0.8.0 (install identity), assetTag is b11960 (download release). - runtime_release_test.dart and docs/runtime.md merged cleanly and now cover both sides: nightly URLs plus releases/forTag, and the bundled-runtime resolution order. docs/status.md, AGENT.md and README.md record 1291 tests (892 core plus two host/env-gated skips, 233 CLI, 166 app) measured on this merge.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related pinning defects:
RuntimeAsset.urlwas built from the install tagv0.8.0, but that release only carriesnightly-tag.txt; the archives live on theb11960nightly build. The URL now uses a separateassetTag, so downloads point atb11960while the install identity staysv0.8.0.tool/build_llama_cpp.shtrusted the tag. For the pinned tag it now reads the commit fromLlamaVersionPin, checks the checkout out at that commit (fetching it when needed), hard-fails when it cannot, and prints the resolved commit.Refs #37
Evidence
Verified with
curl -sSILbefore the change:.../releases/download/v0.8.0/llama-b11960-bin-ubuntu-x64.tar.gz.../releases/download/b11960/llama-b11960-bin-ubuntu-x64.tar.gz.../releases/download/v0.8.0/llama-b11960-bin-win-cpu-x64.zip.../releases/download/b11960/llama-b11960-bin-win-cpu-x64.zip.../releases/download/v0.8.0/llama-b11960-bin-macos-arm64.tar.gz.../releases/download/b11960/llama-b11960-bin-macos-arm64.tar.gz.../releases/download/v0.8.0/nightly-tag.txt.../releases/download/b11960/nightly-tag.txtThe Linux CPU asset now resolves to:
Design note
RuntimeAsset.tagis the install identity: manifests,RuntimeAttestation.verify(manifest.tag == release.tag), the CLIruntime install --tagdefault and the<config>/runtime/<tag>/<backend>layout all depend onv0.8.0. It is unchanged.The new
RuntimeAsset.assetTagis the download release — the GitHub release that physically holds the archive. It is nullable (nullmeans "same astag"), so every otherRuntimeAssetconstructor and test fake keeps working unchanged.urluses${assetTag ?? tag}.RuntimeRelease.v080passesassetTag: 'b11960'to all 12 assets;release.tag,asset.tagandrelease.buildare untouched.tool/build_llama_cpp.shgates commit verification on the pinned tag only. Other tags keep the existing "local experiment" path and version warning; the resolved commit is printed either way so a mismatch is diagnosable.Tests
Core
runtime_release_test.dart:.../download/b11960/and still ends with its asset name;tag == 'v0.8.0'withassetTag == 'b11960';/download/v0.8.0/;Downloader and installer tests route fakes by
asset.url, so they exercise the new URL transparently and still pass.Gate
dart run melos run gentwice (no drift),gen:catalog:check(362 parameters, clean),melos run checkandmelos run format:checkall green:bash -n tool/build_llama_cpp.shis clean.