Repository navigation
chore(packaging): path-context seam and a runtime-bearing macOS bundle in CI - #41
Merged
Merged
Conversation
ServerBinaryLocatorImpl renders every candidate with an optional package:path context, defaulting to the host's, so Windows and macOS shapes are testable on Linux. Two context tests cover the Windows candidate list and the macOS Contents/Resources runtime; suite counts move to 1293 (894 core plus two skips, 233 CLI, 166 app).
The macOS packaging job builds a deterministic fixture runtime (a compiled Mach-O dylib, a libggml-metal copy, a scripted llama-server and a realistic runtime.yaml), packages it under Contents/Resources/runtime, then extracts the archive with ditto and asserts the runtime files, the executable bit, codesign --verify --deep --strict and the absence of the App Sandbox entitlement. docs/packaging.md records the fixture and what remains unverified.
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the two remaining checklist items of #39.
Item A —
pathContextseam forServerBinaryLocatorImplServerBinaryLocatorImplnow takes an optionalp.Context? pathContext(defaultp.context) and renders every join, normalize, dirname, isAbsolute and PATH-list separator through it, mirroringLlamaLibraryLocator. Production defaults and the executability logic are unchanged. New tests cover:p.Style.windows):C:\Program Files\LlamaPulse\data\llama-server.exe, the adjacentllama-server.exe, the configbincandidate and the PATH entry with the bare.exename last;<X.app>/Contents/Resources/runtime/v0.8.0/metal/llama-serveris produced and resolved.Item B — CI verifies a runtime-bearing macOS bundle
The
Package (macOS)job keeps the runtime-free package/upload path and adds:$RUNNER_TEMP— a compiled Mach-Olibllama.dylib, alibggml-metal.dylibcopy, an executablellama-serverscript and a realisticruntime.yaml;package_app.dart --runtime v0.8.0 metal --out dist-runtime;ditto -x -k, then asserts the four runtime files underContents/Resources/runtime/v0.8.0/metal/, the app executable bit,codesign --verify --deep --strict, and nocom.apple.security.app-sandboxentitlement.docs/packaging.mdnow says CI packages a runtime-bearing macOS bundle too, but with a fixture runtime, not a downloaded production archive.Still unverified
Test plan
dart run melos run checkgreen: gen twice with no drift,gen:catalog:check(362 parameters), analyze, 1293 tests (894 core plus two host/env-gated skips, 233 CLI, 166 app),format:check, CLI AOT build.Refs #39