Repository navigation
Fix Node adapter edge cases found in review - #355
Merged
Merged
Conversation
- --agent ../outside.mjs:answer was accepted although the module must be inside the project; any .. segment is now rejected. - The runner imported agentloop-profiler at module load, so a missing package crashed with a raw Node stack trace (exit 1) before --check could report it. It now loads the SDK inside main and exits 2 with the npm install command. - An agent returning before a traced call finished crashed the runner with no trace; it now explains to await trace.tool/model calls. - init for an existing Node project reminds users to install the npm package before --check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AgentLoop replay self-testThis required repository check evaluates generated synthetic demo traces. It tests the replay and CI machinery; it does not show that this PR improves application performance. AgentLoop CI Report
Performance Gates
Trace inputsThis comparison includes synthetic data. It does not establish application performance gains from a pull request.
Metric Impact
Top Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and probing of the unreleased Node.js guided setup (#353) found three bugs:
Also: `init` for an existing Node project prints `npm install agentloop-profiler, then node agentloop_runner.mjs --check`.
Probed by hand: missing SDK, `undefined`/NaN/function outputs, thrown strings, bad stdin, unawaited spans. Tests: unit cases for `../` paths and the CLI hint; the CI Node smoke now checks the missing-SDK and unawaited-span messages. Locally: 30 init tests and the Node smoke pass.
🤖 Generated with Claude Code