Conversation
Work URL and editor tools share one glass row. Editor pills stay neutral; only the live-URL pill takes the project accent.
21 tasks
Bundle ReportChanges will increase total bundle size by 37.34kB (0.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: portfolio-client-array-pushAssets Changed:
Files in
App Routes Affected:
view changes for bundle: portfolio-server-cjsAssets Changed:
Files in
App Routes Affected:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 97.29% 97.27% -0.03%
==========================================
Files 356 360 +4
Lines 9109 9218 +109
Branches 3091 3030 -61
==========================================
+ Hits 8863 8967 +104
- Misses 238 243 +5
Partials 8 8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⇝pull request
*ੈ✩‧₊˚༺☆༻*ੈ✩‧₊˚
what & why
The yellow “Preview Mode aktiv” bar is gone. Draft tools and the work live-URL sit in one glass row at the bottom.
scope
@httpjpg/ui·@httpjpg/storyblok-ui·@httpjpg/storyblok-utils·apps/portfolio·apps/storybookchange type
feat— new feature · Added · minorfix— bug fix · Fixed · patchrefactor/style/revert· Changed · patchperf— faster or leaner · Performance · patchbuild/ci/docs/test· Tooling · patchdeps— dependency bump · Dependencies · patchchore— hidden from the changelog · patchBREAKING CHANGE:footer · ⚠ BREAKING · majorscreenshots / recordings
Work preview keeps the project accent. Editor tools stay on the default glass, same row:
One pill row: orange preview, dark glass draft/edit/exit/grid
Draft without a live URL:
Draft chrome without a work URL: draft, edit, exit, grid
12-column overlay (⊞ or G):
12-column overlay over the same pill row
checklist — every pull request
CLAUDE.md— I read a neighbouring file before inventing a pattern"use client"boundary is as small as possible*.test.ts(x)); E2E updated if a user-facing flow changedpackage.jsonversion,.release-please-manifest.jsonorCHANGELOG.mdnotes for reviewers
Split out of #413. Independent of the margins and motion PRs.
One folder:
packages/ui/src/components/floating-badge/floating-badge.tsxeditor-chrome.tsxpage-badge.tsxhref/editHref/accentColor.DraftChromewraps<main>when a draft cookie /?_draft/?_storyblokis set. Only the live-URL button takes the project accent.Storybook:
Display/FloatingBadgeandDisplay/EditorChrome.To show artifacts inline, enable in settings.