Conversation
Work stories can list downloads by name and URL. When a work page has files, they render as draggable Windows XP-style desktop icons; double-click or Enter starts the download. Placeholder glyphs follow the file extension until real icons are wired through DESKTOP_ICON_SRC.
Bundle ReportChanges will increase total bundle size by 31.39kB (0.18%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: portfolio-client-array-pushAssets Changed:
App Routes Affected:
view changes for bundle: portfolio-server-cjsAssets Changed:
App Routes Affected:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 97.29% 97.35% +0.05%
==========================================
Files 356 360 +4
Lines 9109 9312 +203
Branches 3091 3142 +51
==========================================
+ Hits 8863 9066 +203
Misses 238 238
Partials 8 8
|
A fieldset legend leaked a Work downloads chip onto the overlay. The layer is now a labelled section so the icons stay the only chrome.
Drop the unreachable null-ref guard in favour of currentTarget, and add cases for a foreign pointer id, pointer cancel, kind overrides, and a scheme that URL cannot parse.
24 tasks
Icons already set data-draggable; mount CustomCursor in the XP stage so hover gets the same 👋 animation as the Spotify widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⇝pull request
*ੈ✩‧₊˚༺☆༻*ੈ✩‧₊˚
what & why
Work pages can now carry a
downloadslist (name+url). When any files are set, they render as draggable Windows XP–style desktop icons scattered across the viewport. Double-click (or Enter) starts the download.scope
@httpjpg/ui,@httpjpg/storyblok-ui,@httpjpg/storyblok-sync,@httpjpg/storyblok-utils,@httpjpg/portfolio,@httpjpg/storybookchange type
feat— new feature · Added · minorscreenshots / recordings
Storybook: Widgets / DesktopDownloads. Placeholder glyphs until real 32×32 XP icons land in
DESKTOP_ICON_SRC.Scattered XP-style download icons on a desktop-blue stage
Same icons clamped inside a mobile viewport
checklist — every pull request
CLAUDE.md— I read a neighbouring file before inventing a pattern"use client"boundary is as small as possible@httpjpg/tokensvia Panda (no raw hex outside genuinely off-palette decoration)uinever imports back from consumers)*.test.ts(x)); E2E updated if a user-facing flow changedconsole.login shipped paths; errors reported through@httpjpg/observabilitypackage.jsonversion,.release-please-manifest.jsonorCHANGELOG.mdstoryblok / cms — only if a blok or schema moved
packages/storyblok-sync/scripts/blocks/*(download_itemnestable +work.downloads)sync:componentsstill needs to run against Storyblok (Management API) so editors get the fieldSbDownloadItempage component — same pattern asbadge_item: the parent (SbPageWork) maps the nestable into UI. Not registered inapps/portfolio/lib/storyblok.tsnotes for reviewers
_uid, notMath.random(), so SSR/Storybook/Argos stay stable.position: fixedwithpointer-events: noneon the layer andautoon each icon, so the page still scrolls and clicks through.pdf/zip/image/video/audio/document/file) live inDesktopDownloadPlaceholder. Swap real assets later viaDESKTOP_ICON_SRC(pixelated rendering is already on).name) so “Press kit.pdf” is findable.pnpm --filter @httpjpg/storyblok-sync sync:componentsso the CMS field exists for editors.Verified in Storybook: scatter + extension glyphs, single-click select, click-outside deselect, pointer-drag to pixel coords, double-click opens the file URL, icons stay inside a 390px viewport.
To show artifacts inline, enable in settings.