refactor: weekly cleanup for analytics coverage, desktop-download exports, and agent docs - #456
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…orts, and agent docs Stop re-exporting unused desktop-download helpers, share formatYear on related work, sync Storybook docs after the analytics and video work, and cover the new track* helpers plus provider callbacks.
cursor
Bot
force-pushed
the
cursor/bc-c876aa9f-328c-4a4c-aced-b770fd44efe9-69fe
branch
from
September 22, 2026 22:23
3b11165 to
fd17d69
Compare
Bundle ReportChanges will decrease total bundle size by 1.1kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: portfolio-server-cjsAssets Changed:
App Routes Affected:
view changes for bundle: portfolio-client-array-pushAssets Changed:
App Routes Affected:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 96.95% 97.52% +0.57%
==========================================
Files 360 360
Lines 9551 9551
Branches 3191 3100 -91
==========================================
+ Hits 9260 9315 +55
+ Misses 285 230 -55
Partials 6 6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⇝pull request
॰✩‧₊˚༺☆༻॰✩‧₊˚
what & why
Weekly code cleanup after #441. Tighten the public desktop-download API, share
formatYearon related work, sync Storybook docs with the analytics/video work, and cover the newtrack*helpers plus provider callbacks. Agent docs now describe the event catalog, tracked media providers, and XP desktop downloads.scope
apps/portfolio,apps/storybook,@httpjpg/ui,@httpjpg/analytics,AGENTS.mdchange type
refactor/style/revert· Changed · patchbuild/ci/docs/test· Tooling · patchscreenshots / recordings
Docs and tests only — no visual product change.
checklist — every pull request
pnpm lint,pnpm type-check,pnpm testandpnpm buildpass locallyCLAUDE.md— I read a neighbouring file before inventing a pattern"use client"boundary is as small as possible@httpjpg/tokensvia Panda (no raw hex outside genuinely off-palette decoration)uinever imports back from consumers)packages/env/src/env.mjs,.env.exampleandturbo.json*.test.ts(x)); E2E updated if a user-facing flow changedconsole.login shipped paths; errors reported through@httpjpg/observabilitypackage.jsonversion,.release-please-manifest.jsonorCHANGELOG.mdnotes for reviewers
DESKTOP_ICON_SRC/fileKindFromSourcebarrel re-exports. Internal./libimports stay.formatYear(invalid dates stay hidden; wall-clock CMS dates keep the year from the string).poster/objectFitargTypes; FooterStatusLineonClick; ImageComparisonSlideronInteract; DesktopDownloads cursor copy; leftover “Basic X with live controls” JSDoc stripped.onClose, audio play/pause/skip callbacks,Tracked*Providerwiring, related-work / work-nav / locale / ask error+action events.formatYear).weekly-cleanuplabel applied after open. Previous weekly cleanup refactor: weekly cleanup for shared ICON_NAMES, story catalog, and agent docs #441 is merged.