Allow compositors implementing ext-data-control to sync (bump dependencies) - #53
Open
RedSQL wants to merge 1 commit into
Open
Allow compositors implementing ext-data-control to sync (bump dependencies)#53RedSQL wants to merge 1 commit into
RedSQL wants to merge 1 commit into
Conversation
Fixes issues with clipboard-sync using the fallback path on compositors without zwlr_data_control_manager_v1 support. Now it's upstreamed and is known as ext-data-control-v1, which will be used by wl-clipboard-rs if supported in the compositor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clipboard-synchas relied on0.7.0version ofwl-clipboard-rsthat tried to resolve azwlr_data_control_manager_v1protocol which would fail if not implemented by compositor. Wayland has had an official data control protocol in the upstream for a while now, but the resolution of it would fail simply because thewl-clipboard-rsdependency would not know to look for it.Changes
I have:
wl-clipboard-rsdependencywayland-clienttoo.ConnectErrorenum no longer havingNoCompositorListeningby swapping it withConnectError::NoCompositorclipboard-syncversion number to v0.2.1Now with the new
wl-clipboard-rsversion, compositors implementing either (or both)ext-data-control-v1orwlr-data-control-unstable-v1will work! So any compositors listed here (upstream) and here (wlroots) will have a working clipboard sync now.Additional notes
Sadly I don't think this closes any issue? It might address some that error out with being unable to access clipboard but I am not entirely sure.
I have compiled and ran the target binary with my changes to see if it works, and from my testing it works perfectly fine on my workstation running KDE Plasma 6.7.4.