Repository navigation
Conversation
Clicking a commit in History put its details after the last loaded row, and every paint of the table started it again from the top. So the table jumped when a commit was clicked, and the details showed up at the end of the list, far from the commit and out of view in a long history. The details now open right under the clicked row (a comparison under the row clicked first), and the graph's lanes run on beside them. Opening, loading, switching Tree/List, folding a folder and closing keep the table where it was. Once the details have loaded, the table scrolls to center the row and its details, and only the table scrolls, not the tab around it. Beside the details a lane still bends within one row, then runs straight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #99.
Problem
In Git > History, clicking a commit put its details after the last loaded row, and every repaint of the table (the "Loading…" paint, then the loaded one) started the table again from the top. So:
Fix
scrollIntoViewcould also move the containers around it.Testing
test/project-git-graph-view.test.js: the panel goes under the clicked row (and under the first row of a comparison), scroll is kept across open/load/close, centering waits for the loaded details and stays inside the table, and the bend beside the panel stays one row tall. All six fail onmainand pass with this change.npm test: everything passes except two git tests (fileDiff reads tracked and untracked changes…,projectGitInfo and projectGitDiff expose read-only data…). They fail the same way on a cleanmainhere because of a globalcolor.ui = always, and they pass withGIT_CONFIG_GLOBAL=/dev/null.