deps: raise everything that was behind, and watch what nothing was watching - #38
Merged
Merged
Conversation
…tching An audit of every pinned thing in the repository, prompted by yesterday's migration, where two CI tools turned out to be on versions that could not read Go 1.27 at all. Raised, all of them current as of today and each checked against its own release source rather than recalled: golangci-lint v2.13.1 -> v2.13.2 semgrep 1.175.0 -> 1.176.0 deploy-pages v5.0.0 -> v5.0.1 sbom-action v0.24.0 -> v0.24.2 x/image v0.43.0 -> v0.45.0 x/image is the only one that could have moved bytes, and it does not: every format at two sizes, byte for byte identical across the bump, so D11 holds and no version is owed. The module graph is unchanged at 68, and the notices file carries the new number because those licences ask for the version that actually ships. The comment in webp.go citing what x/image contains was re-read at v0.45.0 rather than carried across with the number changed - it still holds no encoder. The rest of the audit came out clean: ten of twelve actions were already current, five of six direct modules were, and all three Dependabot alerts are fixed with govulncheck finding nothing. The finding is what was NOT being watched. CLAUDE.md says Dependabot keeps these current, and that is true of go.mod and of `uses:` only. Four tool versions live as shell commands inside workflow steps, where it does not look - measured, thirty pull requests from that bot and not one about any of them. Nobody had ignored a warning yesterday. There was never going to be one. Semgrep moves to .github/requirements-semgrep.txt, which is an ecosystem Dependabot reads, so it will now arrive as a pull request. The three Go tools cannot be handled that way, twice over: a token cannot push changes under .github/workflows, so no bot can edit the line they sit on, and putting them in go.mod as tool directives was measured at 69 modules becoming 439 - against immutable rule 11, which asks for a licence check on every one, and against two gates that pin that graph deliberately. So they get a weekly job that reports instead. It reads the pins out of the workflows rather than keeping a copy, and asks the Go module proxy rather than the GitHub releases API - the first version asked GitHub and raised two false alarms out of three, because staticcheck releases under two names at once and x/vuln answered with an older tag than the one pinned. A gate that cries wolf is worse than none. Rolled staticcheck back to v0.7.0 to confirm it goes red, which is the failure it exists for. The semgrep guard was split rather than relaxed: the job has to name the requirements file, and the file has to pin an exact version, so an empty file cannot pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An audit of every pinned thing in the repository, prompted by yesterday's migration, where two CI tools turned out to be on versions that could not read Go 1.27 at all.
Raised
Each checked against its own release source rather than recalled.
golangci-lintsemgrepactions/deploy-pagesanchore/sbom-actiongolang.org/x/imagex/imageis the only one that could have moved bytes, and it does not - every format at two sizes, byte for byte identical across the bump.D11holds and no version is owed. The module graph is unchanged at 68, and the notices file carries the new number because those licences ask for the version that actually ships.The comment in
webp.gociting whatx/imagecontains was re-read at v0.45.0 rather than carried across with the number changed. It still holds no encoder.The rest of the audit came out clean
Ten of twelve actions were already current, five of six direct modules were, and all three Dependabot alerts are
fixedwithgovulncheckfinding nothing.The finding: four pins nothing was watching
CLAUDE.mdsays Dependabot keeps these current, and that is true ofgo.modand ofuses:only. Four tool versions live as shell commands inside workflow steps, where it does not look.Measured: thirty pull requests from that bot, not one about any of them. Nobody had ignored a warning yesterday. There was never going to be one.
Semgrep moves to
.github/requirements-semgrep.txt, an ecosystem Dependabot reads, so it will now arrive as a pull request.The three Go tools cannot be handled that way, twice over. A token cannot push changes under
.github/workflows, so no bot can edit the line they sit on; and putting them ingo.modas tool directives was measured at 69 modules becoming 439 - against immutable rule 11, which asks for a licence check on every one, and against two gates that pin that graph deliberately.So they get a weekly job that reports instead. Two things about how it does that:
v0.8.1is2026.2.1), andx/vulnanswered with an older tag than the one already pinned. A gate that cries wolf is worse than no gate, which is the whole thing this job exists to replace.Confirmed in both directions: rolled
staticcheckback to v0.7.0 and it goes red, naming exactly the failure that cost a session yesterday.Also
The semgrep guard was split rather than relaxed: the job has to name the requirements file, and the file has to pin an exact version, so an empty file cannot pass.
preflight.pygains atoolchaincheck, first in the list, comparinggo versionwith thetoolchainline ingo.mod. It asks rather than sets - puttingGOTOOLCHAINfrom a script would take the setting away from whichever project holds it, which is the same tug of war in the other direction. (tools/is outside the repository, so that part is not in this diff.)What was checked
preflight10 of 10 including the two new tool versionsx/imagebyte neutrality across all 24 formats at two sizesWritten up as
O170.🤖 Generated with Claude Code