Fix minor issues in Blazor CRUD scaffolder - #3818
Open
vendasankarsf3945 wants to merge 4 commits into
Open
vendasankarsf3945 wants to merge 4 commits into
vendasankarsf3945 wants to merge 4 commits into
Conversation
vendasankarsf3945
marked this pull request as ready for review
September 9, 2026 05:10
haileymck
reviewed
Sep 11, 2026
Member
|
Looks great! Happy to merge after unit tests mentioned are added :) |
haileymck
previously approved these changes
Sep 16, 2026
Member
|
happy to reapprove after merge conflicts are resolved |
… into blazor-crud-scaffolder-minor-fixes # Conflicts: # src/dotnet-scaffolding/dotnet-scaffold/AspNet/Templates/net8.0/BlazorCrud/Edit.cs # src/dotnet-scaffolding/dotnet-scaffold/AspNet/Templates/net8.0/BlazorCrud/Edit.tt # src/dotnet-scaffolding/dotnet-scaffold/AspNet/Templates/net9.0/BlazorCrud/Edit.cs # src/dotnet-scaffolding/dotnet-scaffold/AspNet/Templates/net9.0/BlazorCrud/Edit.tt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minor issues in Blazor CRUD scaffolder
Summary
Fixes the remaining Blazor CRUD scaffolder issues identified in #2743 and aligns generated output with current Blazor documentation conventions across .NET 8, .NET 9, .NET 10, and .NET 11 templates.
Root Cause
Several template inconsistencies remained in the Blazor CRUD scaffolder:
NavigationManagerusing the variable nameNavigationManagerinstead of the documentation conventionNavigation.IDbContextFactoryusing a fully-qualified DbContext type even when the namespace was already imported.aria-requiredattribute generation introduced formatting inconsistencies in scaffolded markup.appsettings.jsonremoved the final newline character when rewriting the file.These issues resulted in generated code differing from current documentation patterns and coding conventions.
Changes
Blazor CRUD Templates
to:
NavigationManager.*toNavigation.*.Razor Markup Cleanup
appsettings Formatting
Preserved the final newline when updating:
appsettings.jsonappsettings.Development.jsonUpdated:
AddAspNetConnectionStringStepUpdateAppSettingsStepAddAspireConnectionStringStepValidation
Fixes: #2743