Drop Microsoft.AspNetCore.Grpc.Swagger#67919
Open
Youssef1313 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental Microsoft.AspNetCore.Grpc.Swagger package from the repo (source, tests, and build/solution wiring) as part of deprecating the package and avoiding ongoing dependency/conflict costs (per #67134 / #65228).
Changes:
- Remove the
Microsoft.AspNetCore.Grpc.Swaggerproject, its internal implementation, and its PublicAPI files. - Remove
Microsoft.AspNetCore.Grpc.Swagger.Tests(including protos and test infrastructure). - Remove references to the project from solution filters and build metadata (shipping assemblies, delayed-build list, project reference providers).
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Grpc/JsonTranscoding/test/testassets/Sandbox/Sandbox.csproj | Drops Microsoft.AspNetCore.Grpc.Swagger reference from the sandbox test asset. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlDocumentationIntegrationTests.cs | Removes gRPC Swagger XML comments integration tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlCommentsDocumentFilterTests.cs | Removes document filter tests for XML comment tag descriptions. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocServiceWithComments.cs | Removes XML-doc annotated test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocService.cs | Removes test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/ResponseBodyService.cs | Removes response-body test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/ParametersService.cs | Removes parameters test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/GreeterService.cs | Removes greeter test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/BodyService.cs | Removes body-binding test service used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/SchemaGeneratorIntegrationTests.cs | Removes schema generator integration tests tied to Swagger package internals. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/xmldoc.proto | Removes proto inputs used for Swagger XML docs tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/responsebody.proto | Removes proto inputs used for Swagger response_body tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/parameters.proto | Removes proto inputs used for Swagger parameter binding tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/messages.proto | Removes proto inputs used for schema generation tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/greeter.proto | Removes proto inputs used for basic Swagger generation tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/counter.proto | Removes proto inputs used for Swagger group filtering tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/body.proto | Removes proto inputs used for Swagger request-body binding tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Microsoft.AspNetCore.Grpc.Swagger.Tests.csproj | Removes the Swagger test project. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/TestWebHostEnvironment.cs | Removes test host environment shim used by Swagger tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/OpenApiTestHelpers.cs | Removes Swagger/OpenAPI test helper wiring for AddGrpcSwagger. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/GrpcSwaggerServiceExtensionsTests.cs | Removes tests for AddGrpcSwagger behavior. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/http.proto | Removes vendored Google API HTTP proto used by test protos. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/annotations.proto | Removes vendored Google API annotations proto used by test protos. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/ResponseBodyTests.cs | Removes Swagger response_body binding tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/ParametersTests.cs | Removes Swagger query/path/body parameter binding tests. |
| src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/BodyTests.cs | Removes Swagger body binding tests. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Unshipped.txt | Removes PublicAPI unshipped entries for the dropped package. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Shipped.txt | Removes PublicAPI shipped entries for the dropped package. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Microsoft.AspNetCore.Grpc.Swagger.csproj | Removes the package project definition. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsOperationFilter.cs | Removes operation XML comments filter implementation. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsDocumentFilter.cs | Removes document XML comments filter implementation. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/MessageDescriptorHelpers.cs | Removes proto descriptor helper used by Swagger generation. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcModelMetadata.cs | Removes MVC metadata shim used for XML comments integration. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcJsonTranscodingDescriptionProvider.cs | Removes ApiExplorer provider used to surface transcoded gRPC as API descriptions for Swagger. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcDataContractResolver.cs | Removes serializer contract resolver customizations for protobuf types. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerServiceExtensions.cs | Removes AddGrpcSwagger DI extensions. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerGenOptionsExtensions.cs | Removes IncludeGrpcXmlComments SwaggerGen extensions. |
| src/Grpc/Grpc.slnf | Removes Swagger project/test project from the gRPC solution filter. |
| eng/ShippingAssemblies.props | Removes Microsoft.AspNetCore.Grpc.Swagger from the shipping assemblies list. |
| eng/RequiresDelayedBuildProjects.props | Removes Swagger project/test project from delayed-build list. |
| eng/ProjectReferences.props | Removes Swagger project from reference-provider list. |
| AspNetCore.slnx | Removes Swagger project/test project from the main solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67134
Fixes #65228