Add Swagger metadata compatibility tests and fix nullable overwrites - #11181
Merged
Merged
Conversation
vicancy
changed the title
This was referenced Sep 25, 2026
This was referenced Sep 25, 2026
Open
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Swagger 2.0 compatibility baseline for #11154. Tests cover flexible
infovalues, access through the existing metadata dictionaries, and metadata inheritance and overwrites with tag and operation splitting. They preserve the input shapes accepted by the current implementation, including values outside the Swagger specification.Fix nullable property overwrites that currently discard explicit
falseand0values. Omitted nullable values continue to preserve the original value; both merge and replace behavior are covered.The production diff is limited to two conditions in
ReflectionEntityMerger; the remaining changes add tests in three existing test files.Validation: 94 REST tests, 23 splitting/HTML compatibility tests and 5 entity-merger tests pass on each of .NET 8 and .NET 10. Existing HTML checks cover default, statictoc and modern templates.